Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make container disk images mandatory #231

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Make container disk images mandatory #231

merged 4 commits into from
Apr 9, 2024

Commits on Apr 8, 2024

  1. Config: Make TrafficGenContainerDiskImage mandatory 

    Currently, trafficGenContainerDiskImage defaults to:
`quay.io/kiagnose/kubevirt-dpdk-checkup-traffic-gen:main`.

This may lead to unexpected behavior when using an older
checkup version in combination with the latest traffic-gen
container disk image (tagged as `main`).

Make the field mandatory in order for the user to specify it
explicitly.

Signed-off-by: Orel Misan <[email protected]>
    @orelmisan
    orelmisan committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    d72d339 View commit details
    Browse the repository at this point in the history

  2. README: Make trafficGenContainerDiskImage mandatory 

    Signed-off-by: Orel Misan <[email protected]>
    @orelmisan
    orelmisan committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    f1c10a2 View commit details
    Browse the repository at this point in the history

  3. Config: Make VMUnderTestContainerDiskImage mandatory 

    Currently, vmUnderTestContainerDiskImage defaults to:
`quay.io/kiagnose/kubevirt-dpdk-checkup-vm:main`.

This may lead to unexpected behavior when using an older
checkup version in combination with the latest VM
container disk image (tagged as `main`).

Make the field mandatory in order for the user to specify it
explicitly.

Signed-off-by: Orel Misan <[email protected]>
    @orelmisan
    orelmisan committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    bee8c28 View commit details
    Browse the repository at this point in the history

  4. README: Make vmUnderTestContainerDiskImage mandatory 

    Signed-off-by: Orel Misan <[email protected]>
    @orelmisan
    orelmisan committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    6c6b01a View commit details
    Browse the repository at this point in the history