Implement SkipTeardown Modes #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnongilboa
reviewed
Sep 30, 2024
arnongilboa
reviewed
Sep 30, 2024
alromeros
force-pushed
the
skip-teardown-flag
branch
from
bfb863c
to
52802d9
Compare
|
@alromeros looks good. Can you please document its usage in README.md? |
arnongilboa
reviewed
Oct 10, 2024
arnongilboa
reviewed
Oct 10, 2024
alromeros
force-pushed
the
skip-teardown-flag
branch
from
c455931
to
fed7a22
Compare
arnongilboa
previously approved these changes
Oct 10, 2024
This commit introduces a new SkipTeardown field in the configuration for storage checkups. It allows users to control whether teardown steps should be skipped, improving debugging flexibility. The available modes are: - SkipTeardownAlways: Always skips the teardown process. - SkipTeardownOnFailure: Skips teardown only when a failure occurs (useful for debugging). - SkipTeardownNever: Ensures resources are always cleaned up after a checkup run. Signed-off-by: Alvaro Romero <[email protected]>
Signed-off-by: Alvaro Romero <[email protected]>
alromeros
force-pushed
the
skip-teardown-flag
branch
from
fed7a22
to
ac9a3ff
Compare
|
The linter was complaining about a switch statement lacking |
arnongilboa
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request introduces a new
SkipTeardownfield in the configuration for storage checkups. It allows users to control whether teardown steps should be skipped, improving debugging flexibility.The available modes are:
SkipTeardownAlways(always): Always skips the teardown process.SkipTeardownOnFailure(onfailure): Skips teardown only when a failure occurs (useful for debugging).SkipTeardownNever(never): Ensures resources are always cleaned up after a checkup run.