Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update redirect URL format in AAD App Registration instructions #743

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Update redirect URL format in AAD App Registration instructions #743

merged 1 commit into from
Jan 9, 2024

Conversation

isarns
Copy link
Contributor

@isarns isarns commented Jan 8, 2024

@isarns Can you please also port this and create a PR against the staging branch?

As requested in #741 created a PR for staging

jshaughn
jshaughn approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @isarns !

@jshaughn jshaughn merged commit 6345962 into kiali:staging Jan 9, 2024
5 checks passed
@jshaughn
Copy link
Contributor

jshaughn commented Jan 9, 2024

Just as a comment, the current branch reflects the docs for latest release of Kiali, a change to this branch will only ever apply to that one version. A change to staging will apply to the next release, and all subsequent releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jshaughn jshaughn jshaughn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isarns @jshaughn