MBL-1838: Wire up PLOT query to UI in no-shipping checkout flow #2225
Conversation
| @@ -625,3 +626,20 @@ private func distinctRewards(_ rewards: [Reward]) -> [Reward] { | |||
| return !rewardIds.contains(reward.id) | |||
| } | |||
| } | |||
|
|
|||
| // TODO: Remove this when implementing the API [MBL-1851](https://kickstarter.atlassian.net/browse/MBL-1851) | |||
There was a problem hiding this comment.
Moved this and changed the ticket number. It's no longer needed in NoShippingPledgeViewModel, but still needed here in ManagePledgeViewModel.
| ).materialize() | ||
| } | ||
|
|
||
| self.showPledgeOverTimeUI = Signal.merge( |
There was a problem hiding this comment.
@jovaniks My assumption is that, since this feature is so small, there's no designs for a separate error state. Is that correct? My approach was just to hide the entire element if an error occurs in the BuildPaymentPlan query.
There was a problem hiding this comment.
That’s correct, we don’t have error handling planned for this component at the moment. Do you think it would make sense to add a TODO to revisit this discussion once everyone is back in January
There was a problem hiding this comment.
I'll set myself a reminder in Slack for January! And I'll raise it in the next PLOT meeting.
| @@ -5285,4 +5287,97 @@ final class NoShippingPledgeViewModelTests: TestCase { | |||
| self.showPledgeOverTimeUI.assertValues([false]) | |||
| } | |||
| } | |||
|
|
|||
| func testPledgeOverTimeConfigData_LoadsAfterBuildPledgeQuery() { | |||
There was a problem hiding this comment.
These tests are pretty bare-bones. I'd love to test that the mock query is actually making a GraphQL request for the right amount, but I don't think we have that capability with our current mock infrastructure.
| @@ -393,3 +405,51 @@ final class NoShippingPledgeViewControllerTests: TestCase { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| private let buildPaymentPlanQueryJson_Eligible = """ | |||
There was a problem hiding this comment.
Of note: if we upgrade Apollo, we'll get access to their mocks API. Then it will be really, really easy to mock GraphQL response objects in our tests without all of this verbose json nonsense.
amy-at-kickstarter
force-pushed
the
feat/adyer/mbl-1838
branch
from
8cf1850 to
26a74d9
Compare
📲 What
Hook up the
BuildPaymentPlanQueryto the new PLOT UI.🤔 Why
This means PLOT will start showing live data, instead of mock data.
🛠 How
PledgePaymentIncrementfragment.👀 See
PLOT.demo.small.mp4
📓 Todos