Add types to timecop functions #12
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cs278
force-pushed
the
add-types-to-timecop-functions
branch
3 times, most recently
from
c344d61
to
b7d7657
Compare
A `TypeError` will be thrown if you use the wrong types but it does not exactly match the error thrown by PHP 8.
cs278
force-pushed
the
add-types-to-timecop-functions
branch
from
2503e43
to
0a9769d
Compare
cs278
force-pushed
the
add-types-to-timecop-functions
branch
from
08fe3cf
to
d8703cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #8
timecop_travel(),timecop_freeze(),timecop_scale()now throwTypeErroron PHP ≥ 7 if you pass in an invalid type.This probably warrants a major version bump, at the same time it probably makes sense to drop support for older PHPs.