fix(user): SKFP-941 update user config

src/store/user/thunks.test.tsx

@@ -0,0 +1,55 @@
+import { cloneDeep } from 'lodash';
+import { cleanupConfig } from './thunks';
+import {
+  emptyUserConfig,
+  updatedConfigDashboard,
+  updatedConfigParticipant,
+  updatedConfigSummary,
+  updatedConfigVariant,
+  userConfig,
+  userConfigWithoutVariant,
+} from './thunksTestData';
+
+describe('store/user/thunks', () => {
+  describe('cleanupConfig', () => {
+    it('should return and empty object if config and his update are empty', () => {
+      const result = cleanupConfig(emptyUserConfig, emptyUserConfig);
+      expect(result).toEqual({});
+    });
+    it('should return updated config if config is empty', () => {
+      const result = cleanupConfig(updatedConfigSummary, {});
+      expect(result).toEqual(updatedConfigSummary);
+    });
+    it('should return merged config if config not contains the updated config part', () => {
+      const result = cleanupConfig(updatedConfigVariant, userConfigWithoutVariant);
+      const mergedConfig = { ...cloneDeep(userConfigWithoutVariant), ...updatedConfigVariant };
+      expect(result).toEqual(mergedConfig);
+    });
+
+    it('should return merged config if config and updated summary config are not empty', () => {
+      const result = cleanupConfig(updatedConfigSummary, userConfig);
+      const mergedConfig = cloneDeep(userConfig);
+      mergedConfig.data_exploration.summary = updatedConfigSummary.data_exploration.summary;
+      expect(result).toEqual(mergedConfig);
+    });
+    it('should return merged config if config and updated tables config are not empty', () => {
+      const result = cleanupConfig(updatedConfigParticipant, userConfig);
+      const mergedConfig = cloneDeep(userConfig);
+      mergedConfig.data_exploration.tables.participants =
+        updatedConfigParticipant.data_exploration.tables.participants;
+      expect(result).toEqual(mergedConfig);
+    });
+    it('should return merged config if config and updated variants config are not empty', () => {
+      const result = cleanupConfig(updatedConfigVariant, userConfig);
+      const mergedConfig = cloneDeep(userConfig);
+      mergedConfig.variants = updatedConfigVariant.variants;
+      expect(result).toEqual(mergedConfig);
+    });
+    it('should return merged config if config and updated dashboard config are not empty', () => {
+      const result = cleanupConfig(updatedConfigDashboard, userConfig);
+      const mergedConfig = cloneDeep(userConfig);
+      mergedConfig.dashboard = updatedConfigDashboard.dashboard;
+      expect(result).toEqual(mergedConfig);
+    });
+  });
+});

src/store/user/thunks.ts

@@ -70,28 +70,37 @@ const updateUser = createAsyncThunk<
   },
 );
 
-const cleanupConfig = (config: TUserConfig): TUserConfig => {
+export const cleanupConfig = (updateConfig: TUserConfig, config?: TUserConfig): TUserConfig => {
   // keep last item
   const removeDuplicates = (cols: TColumnStates) =>
     cols.filter((c, i) => !cols.some((other, j) => c.key === other.key && j > i));
 
-  // for every tables in config replace columns with no duplicates
-  keys(config.data_exploration?.tables).forEach((key) => {
-    const path = 'data_exploration.tables.' + key + '.columns';
-    const cols = get(config, path, []);
-    set(config, path, removeDuplicates(cols));
-  });
+  const configMerged = merge(cloneDeep(config), cloneDeep(updateConfig));
 
-  return config;
+  if (updateConfig.data_exploration?.tables) {
+    // for every tables in config replace columns with no duplicates
+    keys(configMerged.data_exploration?.tables).forEach((key) => {
+      const path = 'data_exploration.tables.' + key + '.columns';
+      const cols = get(configMerged, path, []);
+      set(configMerged, path, removeDuplicates(cols));
+    });
+
+    return configMerged;
+  } else if (updateConfig.data_exploration?.summary && config?.data_exploration?.summary) {
+    config.data_exploration.summary = updateConfig.data_exploration.summary;
+    return config;
+  }
+
+  return configMerged;
 };
 
 const updateUserConfig = createAsyncThunk<TUserConfig, TUserConfig, { state: RootState }>(
   'user/updateConfig',
   async (config, thunkAPI) => {
     const state = thunkAPI.getState();
-    const mergedConfig = cleanupConfig(
-      merge(cloneDeep(state?.user?.userInfo?.config), cloneDeep(config)),
-    );
+
+    const mergedConfig = cleanupConfig(cloneDeep(config), cloneDeep(state?.user?.userInfo?.config));
+
     await UserApi.update({ config: mergedConfig });
 
     return mergedConfig;