Skip to content

Commit

Permalink
fix(consequence): skfp-850 use consequencescell from ferlab (#3837)
Browse files Browse the repository at this point in the history
  • Loading branch information
lflangis authored Nov 1, 2023
1 parent 28efcea commit c2a75c6
Show file tree
Hide file tree
Showing 5 changed files with 58 additions and 152 deletions.
100 changes: 51 additions & 49 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"@apollo/client": "^3.5.10",
"@dnd-kit/core": "^4.0.3",
"@dnd-kit/sortable": "^5.1.0",
"@ferlab/ui": "^7.13.4",
"@ferlab/ui": "^7.14.0",
"@loadable/component": "^5.15.2",
"@react-keycloak/core": "^3.2.0",
"@react-keycloak/web": "^3.4.0",
Expand Down
40 changes: 0 additions & 40 deletions src/views/Variants/components/ConsequencesCell/index.module.scss

This file was deleted.

60 changes: 0 additions & 60 deletions src/views/Variants/components/ConsequencesCell/index.tsx

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { useEffect, useState } from 'react';
import intl from 'react-intl-universal';
import { useDispatch } from 'react-redux';
import { Link } from 'react-router-dom';
import ConsequencesCell from '@ferlab/ui/core/components/Consequences/Cell';
import ExternalLink from '@ferlab/ui/core/components/ExternalLink';
import ProTable from '@ferlab/ui/core/components/ProTable';
import { PaginationViewPerQuery } from '@ferlab/ui/core/components/ProTable/Pagination/constants';
Expand Down Expand Up @@ -47,7 +48,6 @@ import { STATIC_ROUTES } from 'utils/routes';
import { truncateString } from 'utils/string';
import { getProTableDictionary } from 'utils/translation';

import ConsequencesCell from '../../../components/ConsequencesCell';
import { SCROLL_WRAPPER_ID, VARIANT_SAVED_SETS_FIELD } from '../../../utils/constants';

import styles from './index.module.scss';
Expand Down Expand Up @@ -121,7 +121,11 @@ const defaultColumns: ProColumnType[] = [

const consequences = geneWithPickedConsequence.consequences?.hits?.edges;
return (
<ConsequencesCell consequences={consequences} symbol={geneWithPickedConsequence.symbol} />
<ConsequencesCell
consequences={consequences}
emptyText={intl.get('no.data.available')}
symbol={geneWithPickedConsequence.symbol}
/>
);
},
},
Expand Down

0 comments on commit c2a75c6

Please sign in to comment.