Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/skfp 934/cavatica bulk import #3894

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Feat/skfp 934/cavatica bulk import #3894

merged 1 commit into from
Feb 5, 2024

Conversation

lflangis
Copy link
Collaborator

@lflangis lflangis commented Feb 5, 2024 •
edited
Loading

#[BUG | FEATURE | DOC] [TITLE]

Description

I added more metadata when CavaticaBulkImport is triggered.

Screenshot

image
image

@lflangis lflangis requested a review from evans-g-crsj February 5, 2024 14:42
@netlify Netlify
Copy link

netlify bot commented Feb 5, 2024 •
edited
Loading

✅ Deploy Preview for portal-pre-prod-kidsfirstdrc ready!

Name Link
🔨 Latest commit e43db3c
🔍 Latest deploy log https://app.netlify.com/sites/portal-pre-prod-kidsfirstdrc/deploys/65c0fb9ae3db1e00089ee18a
😎 Deploy Preview https://deploy-preview-3894--portal-pre-prod-kidsfirstdrc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Feb 5, 2024 •
edited
Loading

✅ Deploy Preview for portal-qa-next-kidsfirstdrc ready!

Name Link
🔨 Latest commit e43db3c
🔍 Latest deploy log https://app.netlify.com/sites/portal-qa-next-kidsfirstdrc/deploys/65c0fb9aa8636400086eb59c
😎 Deploy Preview https://deploy-preview-3894--portal-qa-next-kidsfirstdrc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements 100% 0/0
🟢 Branches 100% 0/0
🟢 Functions 100% 0/0
🟢 Lines 100% 0/0

Test suite run success

0 tests passing in 0 suite.

Report generated by 🧪jest coverage report action from e43db3c

evans-g-crsj
evans-g-crsj requested changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@evans-g-crsj evans-g-crsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to clean up some outdated comments pls

@evans-g-crsj
Copy link
Contributor

I added more metadata when CavaticaBulkImport is triggered.

@lflangis lflangis force-pushed the feat/SKFP-934/cavatica-bulk-import branch from 03deab7 to db75ac2 Compare February 5, 2024 15:04
@lflangis lflangis requested a review from evans-g-crsj February 5, 2024 15:04
@lflangis lflangis force-pushed the feat/SKFP-934/cavatica-bulk-import branch from db75ac2 to e43db3c Compare February 5, 2024 15:15
@lflangis lflangis merged commit 334fede into 2.0 Feb 5, 2024
8 checks passed
@lflangis lflangis deleted the feat/SKFP-934/cavatica-bulk-import branch February 5, 2024 15:20
@lflangis lflangis mentioned this pull request Feb 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evans-g-crsj evans-g-crsj evans-g-crsj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lflangis @evans-g-crsj