Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SKFP-817 adjust Variant entity sample type casing and biospecimen availability mapping #3903

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

aperron-ferlab
Copy link
Contributor

FIX: adjust Variant entity sample type casing and biospecimen availability mapping

  • closes [#SKFP-817(https://d3b.atlassian.net/browse/SKFP-817?focusedCommentId=20584)

Description

This adresses some QA comments for initial SKFP-817

Validation

  • Code Approved
  • Test Coverage
  • QA Done
  • Design/UI Approved from design

Screenshot

image

image

Copy link

netlify bot commented Feb 7, 2024

Deploy Preview for portal-qa-next-kidsfirstdrc ready!

Name Link
🔨 Latest commit 40696ea
🔍 Latest deploy log https://app.netlify.com/sites/portal-qa-next-kidsfirstdrc/deploys/65c3d2aaf4967d0008d3afee
😎 Deploy Preview https://deploy-preview-3903--portal-qa-next-kidsfirstdrc.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 7, 2024

Deploy Preview for portal-pre-prod-kidsfirstdrc ready!

Name Link
🔨 Latest commit 40696ea
🔍 Latest deploy log https://app.netlify.com/sites/portal-pre-prod-kidsfirstdrc/deploys/65c3d2aa93a8120008a7cbca
😎 Deploy Preview https://deploy-preview-3903--portal-pre-prod-kidsfirstdrc.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Feb 7, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 0/0
🟢 Branches 100% 0/0
🟢 Functions 100% 0/0
🟢 Lines 100% 0/0

Test suite run success

0 tests passing in 0 suite.

Report generated by 🧪jest coverage report action from 40696ea

@aperron-ferlab aperron-ferlab merged commit 81e7792 into 2.0 Feb 7, 2024
8 checks passed
@aperron-ferlab aperron-ferlab deleted the fix/skfp-817 branch February 7, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants