Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHPAM-4779: SLA due date value in ProcessInstanceLog table is not upd… #2396

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

nmirasch
Copy link
Contributor

@nmirasch nmirasch commented Mar 12, 2024

…ated after updating process SLA

JIRA: https://issues.redhat.com/browse/RHPAM-4779

referenced Pull Requests:

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • a pull request please add comment: Jenkins retest this

  • a full downstream build please add comment: Jenkins run fdb

  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

Copy link

sonarcloud bot commented Mar 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
7.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@nmirasch nmirasch requested a review from fjtirado March 14, 2024 11:14
Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, astounding work @nmirasch !

@gmunozfe
Copy link
Member

jenkins run fdb

@gmunozfe
Copy link
Member

gmunozfe commented Apr 1, 2024

jenkins do fdb

@gmunozfe gmunozfe added backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch labels Apr 1, 2024
@gmunozfe
Copy link
Member

jenkins do fdb

@gmunozfe
Copy link
Member

@nmirasch could you fix this compilation error in droolsjbpm-integration repository?

[ERROR] /home/jenkins/workspace/KIE/main/fdb/jbpm-main.fdb/bc/kiegroup_droolsjbpm-integration/kie-spring-boot/kie-spring-boot-autoconfiguration/kie-server-spring-boot-autoconfiguration-audit-replication/src/main/java/org/kie/server/spring/boot/autoconfiguration/audit/replication/AuditDataReplicationProcessEventProducer.java:[48,8] org.kie.server.spring.boot.autoconfiguration.audit.replication.AuditDataReplicationProcessEventProducer is not abstract and does not override abstract method processDataChanged(org.kie.api.event.process.ProcessDataChangedEvent) in org.jbpm.process.audit.AbstractAuditLoggerAdapter

@gmunozfe
Copy link
Member

gmunozfe commented Apr 26, 2024

@nmirasch could you fix this compilation error in droolsjbpm-integration repository?

[ERROR] /home/jenkins/workspace/KIE/main/fdb/jbpm-main.fdb/bc/kiegroup_droolsjbpm-integration/kie-spring-boot/kie-spring-boot-autoconfiguration/kie-server-spring-boot-autoconfiguration-audit-replication/src/main/java/org/kie/server/spring/boot/autoconfiguration/audit/replication/AuditDataReplicationProcessEventProducer.java:[48,8] org.kie.server.spring.boot.autoconfiguration.audit.replication.AuditDataReplicationProcessEventProducer is not abstract and does not override abstract method processDataChanged(org.kie.api.event.process.ProcessDataChangedEvent) in org.jbpm.process.audit.AbstractAuditLoggerAdapter

@nmirasch I've just made a first approach in case you want to review and reuse it bf6bf43a2584d7135305ca4c5481fc1c3d102dee

@gmunozfe
Copy link
Member

jenkins do fdb

Copy link

sonarcloud bot commented Apr 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
7.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@gmunozfe
Copy link
Member

Full downstream build has only 1 failure, and it seems unrelated
org.kie.server.springboot.samples.KeycloakKieServerTest.org.kie.server.springboot.samples.KeycloakKieServerTest

@fjtirado fjtirado merged commit df8c5b4 into kiegroup:main Aug 5, 2024
1 of 5 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 5, 2024
#2396)

* RHPAM-4779: SLA due date value in ProcessInstanceLog table is not updated after updating process SLA

* Add test for coverage

---------

Co-authored-by: gmunozfe <[email protected]>
github-actions bot pushed a commit that referenced this pull request Aug 5, 2024
#2396)

* RHPAM-4779: SLA due date value in ProcessInstanceLog table is not updated after updating process SLA

* Add test for coverage

---------

Co-authored-by: gmunozfe <[email protected]>
fjtirado pushed a commit that referenced this pull request Sep 30, 2024
#2396) (#2437)

* RHPAM-4779: SLA due date value in ProcessInstanceLog table is not updated after updating process SLA

* Add test for coverage

---------

Co-authored-by: nmirasch <[email protected]>
Co-authored-by: gmunozfe <[email protected]>
fjtirado pushed a commit that referenced this pull request Sep 30, 2024
#2396) (#2436)

* RHPAM-4779: SLA due date value in ProcessInstanceLog table is not updated after updating process SLA

* Add test for coverage

---------

Co-authored-by: nmirasch <[email protected]>
Co-authored-by: gmunozfe <[email protected]>
gmunozfe added a commit to gmunozfe/jbpm that referenced this pull request Oct 10, 2024
fjtirado added a commit that referenced this pull request Oct 10, 2024
…earch for rem… (#2446)

* Revert "RHPAM-4779: SLA due date value in ProcessInstanceLog table is not upd… (#2396) (#2436)"

This reverts commit 2d8b32b.

* [JBPM-10242] Allow the possibility of disabling linear search for removeJob and getTimerByName operations (#2441)

* Try to cancel timer always, and only search if timer cancellation fails

* Skipping list search completely if !searchIfFailed

* [JBPM-10242] Always skipping linear search

Unless explicilty stated with property org.jbpm.ejb.timer.linear.search

* [JBPM-10242] Disable linear search on condition

Setting org.jbpm.ejb.timer.disable.linear.search and
org.jbpm.ejb.timer.disable.linear.remove to true

* [JBPM-10242] Fixing integration tests

---------

Co-authored-by: krisv <[email protected]>

---------

Co-authored-by: Francisco Javier Tirado Sarti <[email protected]>
Co-authored-by: krisv <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants