fix: cleanup and tests snapshots

kilnfi · Feb 6, 2024 · 3b12388 · 3b12388
1 parent 9e4836b
commit 3b12388
Show file tree

Hide file tree

Showing 50 changed files with 17 additions and 20 deletions.
diff --git a/README.md b/README.md
@@ -126,11 +126,11 @@ The flow processed in [GitHub Actions](https://github.com/features/actions) is t
 
 ### LR Deposit Into Strategy
 
-![](/tests/snapshots/nanos_lrDepositIntoStrategyNormal/00000.png) ![](/tests/snapshots/nanos_lrDepositIntoStrategyNormal/00001.png) ![](/tests/snapshots/nanos_lrDepositIntoStrategyNormal/00002.png) ![](/tests/snapshots/nanos_lrDepositIntoStrategyNormal/00003.png) ![](/tests/snapshots/nanos_lrDepositIntoStrategyNormal/00004.png) ![](/tests/snapshots/nanos_lrDepositIntoStrategyNormal/00005.png)
+![](/tests/snapshots/nanos_lrDepositIntoStrategyNormal/00000.png) ![](/tests/snapshots/nanos_lrDepositIntoStrategyNormal/00001.png) ![](/tests/snapshots/nanos_lrDepositIntoStrategyNormal/00002.png) ![](/tests/snapshots/nanos_lrDepositIntoStrategyNormal/00003.png) ![](/tests/snapshots/nanos_lrDepositIntoStrategyNormal/00004.png) ![](/tests/snapshots/nanos_lrDepositIntoStrategyNormal/00005.png) ![](/tests/snapshots/nanos_lrDepositIntoStrategyNormal/00006.png) ![](/tests/snapshots/nanos_lrDepositIntoStrategyNormal/00007.png)
 
 ### LR Queue Withdrawal
 
-![](/tests/snapshots/nanos_lrQueueWithdrawal/00000.png) ![](/tests/snapshots/nanos_lrQueueWithdrawal/00001.png) ![](/tests/snapshots/nanos_lrQueueWithdrawal/00002.png) ![](/tests/snapshots/nanos_lrQueueWithdrawal/00003.png) ![](/tests/snapshots/nanos_lrQueueWithdrawal/00004.png) ![](/tests/snapshots/nanos_lrQueueWithdrawal/00005.png)
+![](/tests/snapshots/nanos_lrQueueWithdrawal/00000.png) ![](/tests/snapshots/nanos_lrQueueWithdrawal/00001.png) ![](/tests/snapshots/nanos_lrQueueWithdrawal/00002.png) ![](/tests/snapshots/nanos_lrQueueWithdrawal/00003.png) ![](/tests/snapshots/nanos_lrQueueWithdrawal/00004.png) ![](/tests/snapshots/nanos_lrQueueWithdrawal/00005.png) ![](/tests/snapshots/nanos_lrQueueWithdrawal/00006.png) ![](/tests/snapshots/nanos_lrQueueWithdrawal/00007.png)
 
 ### LR Complete Queued Withdrawal
 
@@ -192,7 +192,7 @@ The flow processed in [GitHub Actions](https://github.com/features/actions) is t
 
 ### LR Queue Withdrawal
 
-![](/tests/snapshots/nanox_lrQueueWithdrawal/00000.png) ![](/tests/snapshots/nanox_lrQueueWithdrawal/00001.png) ![](/tests/snapshots/nanox_lrQueueWithdrawal/00002.png) ![](/tests/snapshots/nanox_lrQueueWithdrawal/00003.png) ![](/tests/snapshots/nanox_lrQueueWithdrawal/00004.png) ![](/tests/snapshots/nanox_lrQueueWithdrawal/00005.png)
+![](/tests/snapshots/nanox_lrQueueWithdrawal/00000.png) ![](/tests/snapshots/nanox_lrQueueWithdrawal/00001.png) ![](/tests/snapshots/nanox_lrQueueWithdrawal/00002.png) ![](/tests/snapshots/nanox_lrQueueWithdrawal/00003.png) ![](/tests/snapshots/nanox_lrQueueWithdrawal/00004.png) ![](/tests/snapshots/nanox_lrQueueWithdrawal/00005.png) ![](/tests/snapshots/nanox_lrQueueWithdrawal/00006.png) ![](/tests/snapshots/nanox_lrQueueWithdrawal/00007.png)
 
 ### LR Complete Queued Withdrawal
 

diff --git a/src/handle_finalize.c b/src/handle_finalize.c
@@ -22,7 +22,7 @@ void handle_finalize(ethPluginFinalize_t *msg) {
             msg->result = ETH_PLUGIN_RESULT_OK;
             break;
         case KILN_LR_DEPOSIT_INTO_STRATEGY:
-            msg->numScreens = 2;
+            msg->numScreens = 3;
             msg->result = ETH_PLUGIN_RESULT_OK;
             break;
         case KILN_LR_QUEUE_WITHDRAWAL:

diff --git a/src/handle_provide_parameter.c b/src/handle_provide_parameter.c
@@ -23,12 +23,10 @@ bool compare_addresses(const char *a, const char *b) {
  * otherwise set it to unkwown (-1)
  *
  * @param address: address to compare
- * @param index: index of the erc20 in the context
- * @param context: context to update
  *
  * @returns index of the erc20 in the context or -1 if not found
  */
-int find_lr_known_erc20(const char *address, context_t *context) {
+int find_lr_known_erc20(const char *address) {
     for (size_t i = 0; i < LR_STRATEGIES_COUNT; i++) {
         if (compare_addresses(address, lr_erc20_addresses[i])) {
             return i;
@@ -43,12 +41,10 @@ int find_lr_known_erc20(const char *address, context_t *context) {
  * otherwise set it to unkwown (-1)
  *
  * @param address: address to compare
- * @param index: index of the strategy in the context
- * @param context: context to update
  *
  * @returns index of the strategy in the context or -1 if not found
  */
-int find_lr_known_strategy(const char *address, context_t *context) {
+int find_lr_known_strategy(const char *address) {
     for (size_t i = 0; i < LR_STRATEGIES_COUNT; i++) {
         if (compare_addresses(address, lr_strategy_addresses[i])) {
             return i;
@@ -79,7 +75,7 @@ void handle_lr_deposit_into_strategy(ethPluginProvideParameter_t *msg, context_t
                                      msg->pluginSharedRW->sha3,
                                      0);
             context->param_data.lr_deposit.strategy_to_display =
-                find_lr_known_strategy(address_buffer, context);
+                find_lr_known_strategy(address_buffer);
 
             context->next_param = LR_DEPOSIT_INTO_STRATEGY_TOKEN;
             break;
@@ -90,8 +86,7 @@ void handle_lr_deposit_into_strategy(ethPluginProvideParameter_t *msg, context_t
                                      sizeof(address_buffer),
                                      msg->pluginSharedRW->sha3,
                                      0);
-            context->param_data.lr_deposit.erc20_to_display =
-                find_lr_known_erc20(address_buffer, context);
+            context->param_data.lr_deposit.erc20_to_display = find_lr_known_erc20(address_buffer);
 
             context->next_param = LR_DEPOSIT_INTO_STRATEGY_AMOUNT;
             break;

diff --git a/src/handle_query_contract_id.c b/src/handle_query_contract_id.c
@@ -45,7 +45,7 @@ void handle_query_contract_id(ethQueryContractID_t *msg) {
             break;
 
         case KILN_LR_DEPOSIT_INTO_STRATEGY:
-            strlcpy(msg->version, "Deposit In Strategy", msg->versionLength);
+            strlcpy(msg->version, "Liquid Restaking", msg->versionLength);
             break;
 
         case KILN_LR_QUEUE_WITHDRAWAL:

diff --git a/src/handle_query_contract_ui.c b/src/handle_query_contract_ui.c
@@ -179,6 +179,11 @@ static bool deposit_into_stragey_ui_lr(ethQueryContractUI_t *msg, context_t *con
 
     switch (msg->screenIndex) {
         case 0:
+            strlcpy(msg->title, "EigenLayer", msg->titleLength);
+            strlcpy(msg->msg, "Deposit In Strategy", msg->msgLength);
+            ret = true;
+            break;
+        case 1:
             strlcpy(msg->title, "Strategy", msg->titleLength);
             if (params->strategy_to_display == -1) {
                 strlcpy(msg->msg, "UNKNOWN", msg->msgLength);
@@ -187,7 +192,7 @@ static bool deposit_into_stragey_ui_lr(ethQueryContractUI_t *msg, context_t *con
             }
             ret = true;
             break;
-        case 1:
+        case 2:
             strlcpy(msg->title, "Amount", msg->titleLength);
             amountToString(
                 params->erc20_amount_to_display,

diff --git a/src/kiln_plugin.h b/src/kiln_plugin.h
@@ -113,9 +113,6 @@ typedef struct {
 } lr_queue_withdrawal_t;
 
 typedef struct {
-    // int lr_strategy_to_display[MAX_DISPLAY_COUNT];
-    // int lr_erc20_to_display[MAX_DISPLAY_COUNT];
-    // uint8_t lr_erc20_amount_to_display[MAX_DISPLAY_COUNT][INT256_LENGTH];
 } lr_complete_queued_withdrawal_t;
 
 typedef struct context_t {

diff --git a/tests/snapshots/nanos_lrDepositIntoStrategyNormal/00001.png b/tests/snapshots/nanos_lrDepositIntoStrategyNormal/00001.png
diff --git a/tests/snapshots/nanos_lrDepositIntoStrategyNormal/00002.png b/tests/snapshots/nanos_lrDepositIntoStrategyNormal/00002.png
diff --git a/tests/snapshots/nanos_lrDepositIntoStrategyNormal/00003.png b/tests/snapshots/nanos_lrDepositIntoStrategyNormal/00003.png
diff --git a/tests/snapshots/nanos_lrDepositIntoStrategyNormal/00004.png b/tests/snapshots/nanos_lrDepositIntoStrategyNormal/00004.png
diff --git a/tests/snapshots/nanos_lrDepositIntoStrategyNormal/00005.png b/tests/snapshots/nanos_lrDepositIntoStrategyNormal/00005.png
diff --git a/tests/snapshots/nanos_lrDepositIntoStrategyNormal/00006.png b/tests/snapshots/nanos_lrDepositIntoStrategyNormal/00006.png
diff --git a/tests/snapshots/nanos_lrDepositIntoStrategyNormal/00007.png b/tests/snapshots/nanos_lrDepositIntoStrategyNormal/00007.png
diff --git a/tests/snapshots/nanos_lrDepositIntoStrategyUnknownERC20/00001.png b/tests/snapshots/nanos_lrDepositIntoStrategyUnknownERC20/00001.png
diff --git a/tests/snapshots/nanos_lrDepositIntoStrategyUnknownERC20/00002.png b/tests/snapshots/nanos_lrDepositIntoStrategyUnknownERC20/00002.png
diff --git a/tests/snapshots/nanos_lrDepositIntoStrategyUnknownERC20/00003.png b/tests/snapshots/nanos_lrDepositIntoStrategyUnknownERC20/00003.png
diff --git a/tests/snapshots/nanos_lrDepositIntoStrategyUnknownERC20/00004.png b/tests/snapshots/nanos_lrDepositIntoStrategyUnknownERC20/00004.png
diff --git a/tests/snapshots/nanos_lrDepositIntoStrategyUnknownERC20/00005.png b/tests/snapshots/nanos_lrDepositIntoStrategyUnknownERC20/00005.png
diff --git a/tests/snapshots/nanos_lrDepositIntoStrategyUnknownERC20/00006.png b/tests/snapshots/nanos_lrDepositIntoStrategyUnknownERC20/00006.png
diff --git a/tests/snapshots/nanos_lrDepositIntoStrategyUnknownERC20/00007.png b/tests/snapshots/nanos_lrDepositIntoStrategyUnknownERC20/00007.png
diff --git a/tests/snapshots/nanos_lrDepositIntoStrategyUnknownStrategy/00001.png b/tests/snapshots/nanos_lrDepositIntoStrategyUnknownStrategy/00001.png
diff --git a/tests/snapshots/nanos_lrDepositIntoStrategyUnknownStrategy/00002.png b/tests/snapshots/nanos_lrDepositIntoStrategyUnknownStrategy/00002.png
diff --git a/tests/snapshots/nanos_lrDepositIntoStrategyUnknownStrategy/00003.png b/tests/snapshots/nanos_lrDepositIntoStrategyUnknownStrategy/00003.png
diff --git a/tests/snapshots/nanos_lrDepositIntoStrategyUnknownStrategy/00004.png b/tests/snapshots/nanos_lrDepositIntoStrategyUnknownStrategy/00004.png
diff --git a/tests/snapshots/nanos_lrDepositIntoStrategyUnknownStrategy/00005.png b/tests/snapshots/nanos_lrDepositIntoStrategyUnknownStrategy/00005.png
diff --git a/tests/snapshots/nanos_lrDepositIntoStrategyUnknownStrategy/00006.png b/tests/snapshots/nanos_lrDepositIntoStrategyUnknownStrategy/00006.png
diff --git a/tests/snapshots/nanos_lrDepositIntoStrategyUnknownStrategy/00007.png b/tests/snapshots/nanos_lrDepositIntoStrategyUnknownStrategy/00007.png
diff --git a/tests/snapshots/nanox_lrDepositIntoStrategyNormal/00001.png b/tests/snapshots/nanox_lrDepositIntoStrategyNormal/00001.png
diff --git a/tests/snapshots/nanox_lrDepositIntoStrategyNormal/00002.png b/tests/snapshots/nanox_lrDepositIntoStrategyNormal/00002.png
diff --git a/tests/snapshots/nanox_lrDepositIntoStrategyNormal/00003.png b/tests/snapshots/nanox_lrDepositIntoStrategyNormal/00003.png
diff --git a/tests/snapshots/nanox_lrDepositIntoStrategyNormal/00004.png b/tests/snapshots/nanox_lrDepositIntoStrategyNormal/00004.png
diff --git a/tests/snapshots/nanox_lrDepositIntoStrategyNormal/00005.png b/tests/snapshots/nanox_lrDepositIntoStrategyNormal/00005.png
diff --git a/tests/snapshots/nanox_lrDepositIntoStrategyNormal/00006.png b/tests/snapshots/nanox_lrDepositIntoStrategyNormal/00006.png
diff --git a/tests/snapshots/nanox_lrDepositIntoStrategyNormal/00007.png b/tests/snapshots/nanox_lrDepositIntoStrategyNormal/00007.png
diff --git a/tests/snapshots/nanox_lrDepositIntoStrategyUnknownERC20/00001.png b/tests/snapshots/nanox_lrDepositIntoStrategyUnknownERC20/00001.png
diff --git a/tests/snapshots/nanox_lrDepositIntoStrategyUnknownERC20/00002.png b/tests/snapshots/nanox_lrDepositIntoStrategyUnknownERC20/00002.png
diff --git a/tests/snapshots/nanox_lrDepositIntoStrategyUnknownERC20/00003.png b/tests/snapshots/nanox_lrDepositIntoStrategyUnknownERC20/00003.png
diff --git a/tests/snapshots/nanox_lrDepositIntoStrategyUnknownERC20/00004.png b/tests/snapshots/nanox_lrDepositIntoStrategyUnknownERC20/00004.png
diff --git a/tests/snapshots/nanox_lrDepositIntoStrategyUnknownERC20/00005.png b/tests/snapshots/nanox_lrDepositIntoStrategyUnknownERC20/00005.png
diff --git a/tests/snapshots/nanox_lrDepositIntoStrategyUnknownERC20/00006.png b/tests/snapshots/nanox_lrDepositIntoStrategyUnknownERC20/00006.png
diff --git a/tests/snapshots/nanox_lrDepositIntoStrategyUnknownERC20/00007.png b/tests/snapshots/nanox_lrDepositIntoStrategyUnknownERC20/00007.png
diff --git a/tests/snapshots/nanox_lrDepositIntoStrategyUnknownStrategy/00001.png b/tests/snapshots/nanox_lrDepositIntoStrategyUnknownStrategy/00001.png
diff --git a/tests/snapshots/nanox_lrDepositIntoStrategyUnknownStrategy/00002.png b/tests/snapshots/nanox_lrDepositIntoStrategyUnknownStrategy/00002.png
diff --git a/tests/snapshots/nanox_lrDepositIntoStrategyUnknownStrategy/00003.png b/tests/snapshots/nanox_lrDepositIntoStrategyUnknownStrategy/00003.png
diff --git a/tests/snapshots/nanox_lrDepositIntoStrategyUnknownStrategy/00004.png b/tests/snapshots/nanox_lrDepositIntoStrategyUnknownStrategy/00004.png
diff --git a/tests/snapshots/nanox_lrDepositIntoStrategyUnknownStrategy/00005.png b/tests/snapshots/nanox_lrDepositIntoStrategyUnknownStrategy/00005.png
diff --git a/tests/snapshots/nanox_lrDepositIntoStrategyUnknownStrategy/00006.png b/tests/snapshots/nanox_lrDepositIntoStrategyUnknownStrategy/00006.png
diff --git a/tests/snapshots/nanox_lrDepositIntoStrategyUnknownStrategy/00007.png b/tests/snapshots/nanox_lrDepositIntoStrategyUnknownStrategy/00007.png
diff --git a/tests/src/lrDepositIntoStrategy.test.js b/tests/src/lrDepositIntoStrategy.test.js
@@ -18,7 +18,7 @@ const contractAddr = '0x858646372cc42e1a627fce94aa7a7033e7cf075a'; // strategy m
 const pluginName = 'Kiln';
 const abi_path = `../cal/abis/${contractAddr}.json`;
 const abi = require(abi_path);
-const right_clicks = 5;
+const right_clicks = 6;
 
 nano_models.forEach(function (model) {
   test(

diff --git a/tests/src/lrQueueWithdrawal.test.js b/tests/src/lrQueueWithdrawal.test.js
@@ -53,7 +53,7 @@ nano_models.forEach(function (model) {
         }
       );
       const tx = eth.signTransaction("44'/60'/0'/0", serializedTx, resolution);
-      const right_clicks = 4;
+      const right_clicks = 7;
 
       await waitForAppScreen(sim);
       await sim.navigateAndCompareSnapshots(