Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use urllib instead of requests #1

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Use urllib instead of requests #1

merged 2 commits into from
Feb 11, 2025

Conversation

nkaijala
Copy link
Contributor

Requests doesn't respect the system CA cert storage by default so I in return don't respect requests.

@nkaijala
Copy link
Contributor Author

Code is untested.

@nkaijala nkaijala requested a review from sirkian February 10, 2025 19:08
@sirkian
Copy link
Collaborator

sirkian commented Feb 11, 2025

LGTM

@sirkian sirkian merged commit f600377 into main Feb 11, 2025
@nkaijala nkaijala deleted the nkaijala-port-to-urllib branch February 11, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants