-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add raw data for 2012 winners #35
Conversation
How about moving data into |
I also don't like that people names are just names - there could be data loss if names match. Is it possible to detect duplicates and export ids as well? |
@abitrolly sounds good to me let's merge this and fix/add your suggestions in subsequent prs/sprints |
LGTM. Don't you mind moving it into https://github.com/kinaklub/next.filmfest.by/tree/master/data/raw ? |
@@ -0,0 +1,209 @@ | |||
[ | |||
{ | |||
"film_title_en": "The Great Race", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we need to calculate id to films based on lower case name + year
or id it to exist films data base with stub data
i will open separate ticket for that for future sprints
@abitrolly is that ticket #45 what you are talking about? |
#46 -оne more ticket for future sprint |
@davojta it is better to avoid too many file moves, because it complicates history navigation. |
@abitrolly so need to fix it here ) |
@nott it is your private branch, can you finish it by yourself ? |
this should be close as work have been moved to #56 |
close |
I think we can benefit from committing data separately from migrations. I didn't have enough time to finish the migration, so I'm committing everything I've finished so far.