Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add raw data for 2012 winners #35

Closed
wants to merge 1 commit into from

Conversation

staaas
Copy link
Collaborator

@staaas staaas commented Aug 10, 2016

I think we can benefit from committing data separately from migrations. I didn't have enough time to finish the migration, so I'm committing everything I've finished so far.

@abitrolly
Copy link
Member

How about moving data into /data and add README.md describing how it is used and how to use it? This is essentially an open data project. It will also allow us to mature data/api tree structure for subsequent access.

@abitrolly
Copy link
Member

I also don't like that people names are just names - there could be data loss if names match. Is it possible to detect duplicates and export ids as well?

@staaas
Copy link
Collaborator Author

staaas commented Aug 10, 2016

@abitrolly sounds good to me

let's merge this and fix/add your suggestions in subsequent prs/sprints

@abitrolly
Copy link
Member

LGTM. Don't you mind moving it into https://github.com/kinaklub/next.filmfest.by/tree/master/data/raw ?

@@ -0,0 +1,209 @@
[
{
"film_title_en": "The Great Race",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we need to calculate id to films based on lower case name + year
or id it to exist films data base with stub data

i will open separate ticket for that for future sprints

@davojta
Copy link
Member

davojta commented Aug 26, 2016

@abitrolly is that ticket #45 what you are talking about?

@davojta
Copy link
Member

davojta commented Aug 26, 2016

#46 -оne more ticket for future sprint

@abitrolly
Copy link
Member

@davojta it is better to avoid too many file moves, because it complicates history navigation.

@davojta
Copy link
Member

davojta commented Aug 27, 2016

@abitrolly so need to fix it here )

@davojta
Copy link
Member

davojta commented Aug 27, 2016

@nott it is your private branch, can you finish it by yourself ?

@davojta davojta mentioned this pull request Oct 26, 2016
@davojta
Copy link
Member

davojta commented Oct 26, 2016

this should be close as work have been moved to #56

@davojta
Copy link
Member

davojta commented Oct 26, 2016

close

@davojta davojta closed this Oct 26, 2016
@abitrolly abitrolly added this to the Bootstrap milestone Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants