-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard): create right panel with user/creator modes and activ… #122
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis update introduces several new UI components to the dashboard interface. A new Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant DL as DashboardLayout
participant RP as RightPanel
participant NM as NavigationMenu
participant LU as LatestUpdates
participant RA as RecentActivity
participant RS as Service
U->>DL: Open dashboard
DL->>RP: Render right panel
RP->>NM: Toggle mode (User/Creator)
RP->>LU: Lazy load latest updates
RP->>RA: Lazy load recent activity
LU->>RS: getLatestUpdates()
RA->>RS: getRecentActivities()
RS-->>LU: Return mock updates
RS-->>RA: Return mock activities
U->>NM: Interact with navigation links
Assessment against linked issues
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 14
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (11)
apps/web/app/(routes)/dashboard/layout.tsx
(1 hunks)apps/web/components/base/scroll-area.tsx
(1 hunks)apps/web/components/sections/user/right-panel/index.tsx
(1 hunks)apps/web/components/sections/user/right-panel/latest-updates.tsx
(1 hunks)apps/web/components/sections/user/right-panel/lazy-components.tsx
(1 hunks)apps/web/components/sections/user/right-panel/navigation-menu.tsx
(1 hunks)apps/web/components/sections/user/right-panel/recent-activity.tsx
(1 hunks)apps/web/lib/constants/mock-data/right-panel-mocks.ts
(1 hunks)apps/web/lib/services/right-panel-service.ts
(1 hunks)apps/web/lib/types/right-side-panel.ts
(1 hunks)apps/web/package.json
(1 hunks)
🔇 Additional comments (5)
apps/web/components/sections/user/right-panel/lazy-components.tsx (1)
5-13
: LGTM! Well-structured skeleton components with consistent implementation.The skeleton components are well-implemented with:
- Consistent spacing using Tailwind's space-y utilities
- Appropriate height values for different content types
- Good use of map for repeated elements
Also applies to: 15-27, 29-41
apps/web/components/base/scroll-area.tsx (1)
7-23
: LGTM! Well-implemented ScrollArea with proper ref forwarding.The ScrollArea component is well-implemented with:
- Proper type definitions
- Good use of className merging
- Built-in accessibility from Radix UI
apps/web/components/sections/user/right-panel/navigation-menu.tsx (1)
56-84
: Great implementation of accessibility features!The component demonstrates excellent accessibility practices:
- Proper ARIA labels for navigation and items
- Semantic HTML with
nav
element- Hidden decorative icons
- Focus management with visible outlines
apps/web/components/sections/user/right-panel/recent-activity.tsx (1)
30-69
: Great implementation of accessible scrollable content!The ScrollArea implementation demonstrates excellent practices:
- Proper ARIA labels and roles
- Semantic HTML structure
- Accessible button elements with descriptive labels
- Proper time element usage with datetime attribute
apps/web/package.json (1)
23-23
: Verify the package version and check for vulnerabilities.The added Radix UI ScrollArea package uses a caret version range which could lead to unexpected updates.
Let's verify the package version and check for any known vulnerabilities:
✅ Verification successful
Radix UI ScrollArea Dependency Verified
- The package version is confirmed as 1.2.2—the latest available release.
- The vulnerability audit (once bypassing the husky prepare hook using --ignore-scripts) does not report known issues.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check the latest version and vulnerabilities for @radix-ui/react-scroll-area # Check npm for latest version echo "Latest version:" npm view @radix-ui/react-scroll-area version # Check for known vulnerabilities echo -e "\nVulnerability check:" npm audit @radix-ui/react-scroll-areaLength of output: 539
Script:
#!/bin/bash # Description: Generate a package-lock file in apps/web and run a vulnerability audit set -e # Navigate to the web app directory containing the package.json cd apps/web echo "Creating package-lock.json (if not already present)..." npm i --package-lock-only echo -e "\nChecking the latest version for @radix-ui/react-scroll-area:" npm view @radix-ui/react-scroll-area version echo -e "\nRunning vulnerability audit for @radix-ui/react-scroll-area:" npm audit @radix-ui/react-scroll-area || trueLength of output: 451
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tks a lot Anouk for taking care of the issue
Pull Request Overview
📝Summary
Implements the right-side panel component for the KindFi User Dashboard, featuring mode switching between User/Creator views, latest updates feed, and recent activity tracking with responsive design and accessibility support.
🪧 Related Issues
Closes #53
🏁 Type of Change
[x] 👌 Enhancement (non-breaking change which adds functionality)
🔄 Changes Made
🚀 Implementation Details
1. Core Components:
2. Technical Features:
🛠 Technical Notes
✅ Tests Results
Test Coverage
[x] 📟 Manual Testing
📸 Evidence
Summary by CodeRabbit