Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing decision headers and carry forward headers to on_commit actions #107

Merged

Conversation

gk-kindred
Copy link
Collaborator

No description provided.

);
tokio::spawn({
let decision_headers = DecisionHeaderBuilder::with_additional_headers(headers.into()).add_meta_headers(DecisionMetaHeaders::new(
1_u64, // major version of decision message
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to keep it somewhere like a constant or "static field", visible. Here it is a bit buried in the code logic.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting that. Will update it today

@gk-kindred gk-kindred merged commit ae02be5 into master Sep 9, 2024
2 checks passed
@gk-kindred gk-kindred deleted the feature/update-decision-and-on-commit-message-headers branch September 9, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants