Add options for full array syntax (allows duplicate checks)

kirschbaum-development · Feb 23, 2021 · 4046100 · 4046100
1 parent d3d282e
commit 4046100
Show file tree

Hide file tree

Showing 3 changed files with 57 additions and 0 deletions.
diff --git a/src/Commands/PreflightCheckCommand.php b/src/Commands/PreflightCheckCommand.php
@@ -108,6 +108,11 @@ protected function bootChecks()
                 $options = [];
             }
 
+            if (is_array($options) && array_key_exists('check', $options)) {
+                $class = $options['check'];
+                $options = $options['options'] ?? [];
+            }
+
             $this->preflightSteps[] = App::makeWith($class, compact('options'));
         }
     }

diff --git a/tests/Checks/Fixtures/OptionsCheck.php b/tests/Checks/Fixtures/OptionsCheck.php
@@ -0,0 +1,14 @@
+<?php
+
+namespace Kirschbaum\PreflightChecks\Tests\Checks\Fixtures;
+
+use Kirschbaum\PreflightChecks\Checks\PreflightCheck;
+use Kirschbaum\PreflightChecks\Checks\Result;
+
+class OptionsCheck extends PreflightCheck
+{
+    public function check(Result $result): Result
+    {
+        return $this->options['pass'] ? $result->pass() : $result->fail();
+    }
+}
diff --git a/tests/Commands/PreflightCheckCommandTest.php b/tests/Commands/PreflightCheckCommandTest.php
@@ -7,6 +7,7 @@
 use Kirschbaum\PreflightChecks\Checks\Exceptions\NoPreflightChecksDefinedException;
 use Kirschbaum\PreflightChecks\PreflightChecksServiceProvider;
 use Kirschbaum\PreflightChecks\Tests\Checks\Fixtures\FailedCheck;
+use Kirschbaum\PreflightChecks\Tests\Checks\Fixtures\OptionsCheck;
 use Kirschbaum\PreflightChecks\Tests\Checks\Fixtures\PassedCheck;
 use Kirschbaum\PreflightChecks\Tests\Checks\Fixtures\SkippedCheck;
 use Kirschbaum\PreflightChecks\Tests\Checks\Fixtures\SkippedFailedCheck;
@@ -58,6 +59,43 @@ public function providesCommandScenarios()
             'Passes with mix of failed skipped' => [
                 [PassedCheck::class, SkippedFailedCheck::class], 0,
             ],
+            'Provides options and passes' => [
+                [
+                    OptionsCheck::class => ['pass' => true],
+                ], 0,
+            ],
+            'Provides options and fails' => [
+                [
+                    OptionsCheck::class => ['pass' => false],
+                ], 1,
+            ],
+            'Can pass full config without options' => [
+                [
+                    [
+                        'check' => PassedCheck::class,
+                    ],
+                ], 0,
+            ],
+            'Can fail full config with options' => [
+                [
+                    [
+                        'check' => OptionsCheck::class,
+                        'options' => ['pass' => false],
+                    ],
+                ], 1,
+            ],
+            'Full config allows duplicates' => [
+                [
+                    [
+                        'check' => OptionsCheck::class,
+                        'options' => ['pass' => false],
+                    ],
+                    [
+                        'check' => OptionsCheck::class,
+                        'options' => ['pass' => true],
+                    ],
+                ], 1,
+            ],
         ];
     }