Merge pull request #6 from kirschbaum-development/handle-boolean-conf…

…ig-values Properly handle boolean config values set to `false`
kirschbaum-development · Feb 20, 2024 · f7cbb2a · f7cbb2a
2 parents c82edec + e407b34
commit f7cbb2a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/Checks/PreflightCheck.php b/src/Checks/PreflightCheck.php
@@ -123,7 +123,9 @@ protected function checkConfig(Result $result): Result
         $missingKeys = [];
 
         foreach ($this->requiredConfig as $configKey) {
-            if (! config()->has($configKey) || empty(config($configKey))) {
+            $configValue = config($configKey);
+
+            if (! is_bool($configValue) && empty($configValue)) {
                 $missingKeys[] = $configKey;
             }
         }

diff --git a/tests/Checks/ConfigurationTest.php b/tests/Checks/ConfigurationTest.php
@@ -27,6 +27,19 @@ public function testPassesWhenConfigIsSet()
         $this->assertPassed($result);
     }
 
+    /**
+     * @test
+     */
+    public function testPassesWhenConfigIsBooleanAndSetToFalse()
+    {
+        $config = ['test1' => false];
+        config($config);
+        $preflightCheck = new Configuration(array_keys($config));
+
+        $result = $preflightCheck->check(new Result('Test\Test'));
+        $this->assertPassed($result);
+    }
+
     /**
      * @test
      */