Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort template projects by title #5745

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

solth
Copy link
Member

@solth solth commented Aug 9, 2023

Fixes #5728
Fixes #5645

@henning-gerhardt
Copy link
Collaborator

For creating / editing new process templates the sorting of projects is now correct. But this change did not fixes the issue #5728 as the sorting in the overview is still incorrect. In the past I missed to add a screenshot (which I did now) and even here:
Screenshot_2023-10-02_16-06-17

Sorry for the late reply and the missing screenshot :-(

@solth
Copy link
Member Author

solth commented Oct 2, 2023

But this change did not fixes the issue #5728 as the sorting in the overview is still incorrect.

You added this aspect to the existing issue 5728, but isn't that already described in the separate different issue #5645 ? So this pull request does indeed resolve issue 5728 in it's original form and description, I think.

@henning-gerhardt
Copy link
Collaborator

Issue #5728 is a full duplicate of #5645 which was even opened by me.

How should we go?

@solth
Copy link
Member Author

solth commented Oct 2, 2023

@henning-gerhardt in my opinion #5728 and #5645 originally described two different aspects and were not actually duplicates: 5728 is about the order of assigned projects in the "template edit" page, while 5645 described the order of projects in the row expansion of the template list.

Since both pages load the data from different sources (template edit page loads the whole template bean from the database while template list loads data from the index), they require distinct solutions. Therefore I think we should treat them as similar, but separate issues that can and have to be resolved individually. Then, this PR would still fix 5728 while the other issue would remain open.

@henning-gerhardt
Copy link
Collaborator

henning-gerhardt commented Oct 2, 2023

In #5728 I added only the screenshot but the description was already there (visible if you look into the first version) and even #5645 describe already both. So in my opinion there are the same but in a different order. But I can change #5728 to the new / edit project template issue and editing #5645 to the the overview issue.

@solth
Copy link
Member Author

solth commented Oct 10, 2023

@henning-gerhardt no need to change the issue descriptions. I have added a commit so that this pull request should cover both lists and issues.

Copy link
Collaborator

@henning-gerhardt henning-gerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good in code and functionality as now the project lists are sorted.

@solth solth merged commit 4ed1bf7 into kitodo:master Oct 10, 2023
2 checks passed
@solth solth deleted the sort-template-projects branch October 10, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants