Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of flyway-maven-plugin (required for newer MariaDB) #6133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stweil
Copy link
Member

@stweil stweil commented Jul 18, 2024

The latest version 10.15.2 cannot be used:

Error:  Failed to execute goal org.flywaydb:flyway-maven-plugin:10.15.2:baseline (default) on project kitodo-data-management: Execution default of goal org.flywaydb:flyway-maven-plugin:10.15.2:baseline failed: Unable to load the mojo 'baseline' in the plugin 'org.flywaydb:flyway-maven-plugin:10.15.2' due to an API incompatibility: org.codehaus.plexus.component.repository.exception.ComponentLookupException: org/flywaydb/maven/BaselineMojo has been compiled by a more recent version of the Java Runtime (class file version 61.0), this version of the Java Runtime only recognizes class file versions up to 55.0

Therefore the update only updates to 9.22.3.

@henning-gerhardt
Copy link
Collaborator

I have on my local environment system even a more recent version of MariaDB running but I did not get this error. Maybe this error appear only on your system with a not yet official supported Java version for the application?

@stweil
Copy link
Member Author

stweil commented Jul 18, 2024

Hallo Henning, mein Kommentar besagt lediglich, dass ich die Version "nur" auf 9.22.3 aktualisiere, weil sich ein Update auf die neueste Version 10.15.2 nicht mit dem bisher noch hauptsächlich verwendeten Java 11 verträgt und dort in der CI den oben genannten Fehler anzeigen würde.

Copy link
Collaborator

@henning-gerhardt henning-gerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least I can still access my local and inhouse used databases. I did not try to migrate any database itself.

pom.xml Outdated Show resolved Hide resolved
@stweil stweil requested a review from solth July 19, 2024 13:17
pom.xml Outdated Show resolved Hide resolved
@stweil
Copy link
Member Author

stweil commented Jul 30, 2024

I added a commit which fixes issue #6153 by supporting flyway commands from the root. See also the related discussion in #6127.

@henning-gerhardt
Copy link
Collaborator

henning-gerhardt commented Jul 30, 2024

Your additional commit is not bad and I can run the flyway based migration from the root source directory which was not possible before - thanks for that. But I would updating the used flyway version and the changed use of flyway in separate pull requests and the changes here did not fix not the main issue from #6127.

You must adjust the default CI workflow file too as there still a special actions file is in use and this file can hide wrong behavior while CI executing. Don't ask me why the copy command one line before is needed and what is is doing.

@stweil
Copy link
Member Author

stweil commented Jul 30, 2024

the changes here did not fix not the main issue from #6127

I had added the important commit which fixes #6127 only recently. Maybe it was still missing in your test.

Splitting the PR in several independent parts seems like a good idea. I'll do this.

@stweil
Copy link
Member Author

stweil commented Jul 30, 2024

I removed the additional commits now and created new pull requests for them (see #6158 and #6159).

@stweil
Copy link
Member Author

stweil commented Oct 31, 2024

Rebased + fixed merge conflict.

The latest version 10.15.2 cannot be used:
```
Error:  Failed to execute goal org.flywaydb:flyway-maven-plugin:10.15.2:baseline (default) on project kitodo-data-management: Execution default of goal org.flywaydb:flyway-maven-plugin:10.15.2:baseline failed: Unable to load the mojo 'baseline' in the plugin 'org.flywaydb:flyway-maven-plugin:10.15.2' due to an API incompatibility: org.codehaus.plexus.component.repository.exception.ComponentLookupException: org/flywaydb/maven/BaselineMojo has been compiled by a more recent version of the Java Runtime (class file version 61.0), this version of the Java Runtime only recognizes class file versions up to 55.0
```

Signed-off-by: Stefan Weil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants