Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: load and format lend menu data #314

Open
wants to merge 14 commits into
base: www-header
Choose a base branch
from

Conversation

christian14b
Copy link
Collaborator

No description provided.

@kiva/kv-components/package.json Outdated Show resolved Hide resolved
@kiva/kv-components/package.json Outdated Show resolved Hide resolved
* @param {string} [key] - compare property 'key' of elements rather than the elements themselves
* @returns {function}
*/
export function indexIn(list, key) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@christian14b christian14b marked this pull request as ready for review November 20, 2023 21:48
const menuComponent = ref(null);
const menuComponent = shallowRef(null);
const menuComponentInstance = ref(null);
const userId = ref(props.userId);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

userId should be declared as a prop, and then it will be available in the template and won't need to be declared here.

Copy link
Collaborator

@emuvente emuvente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just one thing to clear up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants