Skip to content

Commit

Permalink
Merge pull request #5613 from kiva/fix-badge-share-title
Browse files Browse the repository at this point in the history
fix: get loan number in title from badge target
  • Loading branch information
christian14b authored Oct 22, 2024
2 parents 677189e + 37c3d66 commit 2f9119b
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 5 deletions.
18 changes: 16 additions & 2 deletions src/composables/useBadgeContentfulData.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,17 @@ export const badgeQuery = gql`query contentfulBadgeImage ($badgeKey: String!) {
}
}`;

// Targets defined for each level
const levelsTarget = {
level1: 2,
level2: 3,
level3: 5,
level4: 10,
level5: 20,
level6: 50,
level7: 100,
};

export default function useBadgeContentfulData(client, route) {
const utmCampaign = route?.query?.utm_campaign ?? '';
const isUtmValid = utmCampaign.includes('badge_') && utmCampaign.includes('social_share');
Expand All @@ -16,6 +27,7 @@ export default function useBadgeContentfulData(client, route) {
const loadBadgeInfo = async () => {
let badgeImage = null;
let badgeCategory = '';
let badgeTarget = 0;

try {
const data = client.readQuery({
Expand All @@ -27,21 +39,23 @@ export default function useBadgeContentfulData(client, route) {
if (contentfulData) {
badgeImage = contentfulData?.[0]?.fields?.badgeImage?.fields?.file?.url ?? null;
badgeCategory = contentfulData?.[0]?.fields?.challengeName ?? '';
badgeTarget = levelsTarget?.[`level${contentfulData?.[0]?.fields?.level}`] ?? 0;
}
} catch (e) {
logReadQueryError(e, 'useBadgeContentfulData');
}

return {
badgeImage,
badgeCategory
badgeCategory,
badgeTarget,
};
};

return {
badgeQuery,
badgeKey,
isBadgeKeyValid: isUtmValid && defaultBadges.includes(badgeKey),
isBadgeKeyValid: isUtmValid && defaultBadges.some(badgeName => badgeKey.includes(badgeName)),
loadBadgeInfo,
};
}
7 changes: 4 additions & 3 deletions src/pages/LenderProfile/LenderProfile.vue
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ export default {
enableBadgeContent: false,
badgeImage: null,
badgeCategory: '',
badgeTarget: 0,
};
},
apollo: {
Expand All @@ -125,8 +126,7 @@ export default {
},
pageTitle() {
if (this.enableBadgeContent) {
const checkoutLoans = this.$route.query?.badgeLoans ?? 0;
return `${this.lenderName} has supported ${checkoutLoans} to ${this.badgeCategory}`;
return `${this.lenderName} has supported ${this.badgeTarget} to ${this.badgeCategory}`;
}
let title = `Lender > ${this.lenderName}`;
Expand Down Expand Up @@ -169,9 +169,10 @@ export default {
const { isBadgeKeyValid, loadBadgeInfo } = useBadgeContentfulData(this.apollo, this.$route);
if (isBadgeKeyValid) {
const { badgeImage, badgeCategory } = await loadBadgeInfo();
const { badgeImage, badgeCategory, badgeTarget } = await loadBadgeInfo();
this.badgeImage = badgeImage;
this.badgeCategory = badgeCategory;
this.badgeTarget = badgeTarget;
this.enableBadgeContent = true;
}
}
Expand Down

0 comments on commit 2f9119b

Please sign in to comment.