Skip to content

Commit

Permalink
Merge pull request #5616 from kiva/fix-filter-external-load-errors-se…
Browse files Browse the repository at this point in the history
…ntry

fix: remove px filter, filter out external failed load sentry events
  • Loading branch information
mcstover authored Oct 25, 2024
2 parents c212cf5 + f5425d0 commit 82cb502
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions src/client-entry.js
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,15 @@ async function setupSentry(app, router) {
&& eventAsString.indexOf('pagead') !== -1) {
return false;
}
// Skip sending failed loads of pX
if (eventAsString.indexOf("Cannot set property 'PX1065' of undefined") !== -1) {
// Skip Load failed caused by failed fetch calls in 3rd party libraries
// NOTE: we do see failed loads for our own async modules, this doesn't filter those out
// Sentry Event Link: https://kiva.sentry.io/issues/3808313433/events/427b92cf47ed4aaeb321caf20783eba0/
if (eventAsString.indexOf('Load failed') !== -1
&& (
(eventAsString.indexOf('ct.pinterest') !== -1)
|| (eventAsString.indexOf('rum.management') !== -1)
)
) {
return false;
}
// Skip sending errors from CefSharp
Expand Down

0 comments on commit 82cb502

Please sign in to comment.