Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: random issues resolved with my kiva work #5603

Merged
merged 1 commit into from
Oct 15, 2024
Merged

fix: random issues resolved with my kiva work #5603

merged 1 commit into from
Oct 15, 2024

Conversation

dyersituations
Copy link
Collaborator

https://kiva.atlassian.net/browse/MP-937

I tested the MyKiva work that we have so far and ran into a number of small issues that I resolved:

  • hero element sizing and positioning
  • name left aligned mobile
  • carousel overflow issue -> page scrolls
  • carousel slides size incorrectly on page resize
  • removed small green border around borrower avatars
  • newline before borrower card “view details”
  • settings modal height issue (not full parent)
  • scrollbar appears when settings menu opened/closed
  • settings menu navigation links could be hovered but not clicked on the top/bottom edges
  • settings menu height changes during slide animation

roger-in-kiva
roger-in-kiva approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@roger-in-kiva roger-in-kiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dyersituations dyersituations merged commit 5994eab into main Oct 15, 2024
5 checks passed
@dyersituations dyersituations deleted the fix-mykiva-scroll branch October 15, 2024 23:42
@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 3.1.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 3.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcstover mcstover mcstover approved these changes

@christian14b christian14b christian14b approved these changes

@roger-in-kiva roger-in-kiva roger-in-kiva approved these changes

Assignees
No one assigned
Labels
released on @staging released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dyersituations @kiva-robot @mcstover @christian14b @roger-in-kiva