Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove px filter, filter out external failed load sentry events #5616

Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix: remove px filter, filter out external failed load sentry events #5616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/client-entry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,15 @@ async function setupSentry(app, router) {
&& eventAsString.indexOf('pagead') !== -1) {
return false;
}
// Skip sending failed loads of pX
if (eventAsString.indexOf("Cannot set property 'PX1065' of undefined") !== -1) {
// Skip Load failed caused by failed fetch calls in 3rd party libraries
// NOTE: we do see failed loads for our own async modules, this doesn't filter those out
// Sentry Event Link: https://kiva.sentry.io/issues/3808313433/events/427b92cf47ed4aaeb321caf20783eba0/
if (eventAsString.indexOf('Load failed') !== -1
&& (
(eventAsString.indexOf('ct.pinterest') !== -1)
|| (eventAsString.indexOf('rum.management') !== -1)
)
) {
return false;
}
// Skip sending errors from CefSharp
Expand Down
Loading