Skip to content
This repository has been archived by the owner on Aug 26, 2024. It is now read-only.

Pass request context to frame observer #45

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

martin-sucha
Copy link
Collaborator

This allows the frame observer to access the context passed to gocql.

Copy link

@medasx medasx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking: I wonder whether it would be possible without passing context to callReq. As I see it would require many more changes.

@martin-sucha
Copy link
Collaborator Author

Good point. We can't easily get rid of frameParseObserver.reqCtx (that would require moving all the frame parsing code to one place), but we don't need to store the context in callReq. Thanks!

@martin-sucha martin-sucha force-pushed the ms/frame-observer-context branch from 5d441b4 to a97d7f1 Compare October 30, 2023 14:23
This allows the frame observer to access the context passed to
gocql.
@martin-sucha martin-sucha force-pushed the ms/frame-observer-context branch from a97d7f1 to ab841b4 Compare October 30, 2023 14:28
Copy link

@medasx medasx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martin-sucha martin-sucha merged commit d7209ab into master Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants