Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snapshot test regeneration job #855

Merged
merged 3 commits into from
Nov 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ jobs:
strategy:
matrix:
device: ["iPhone SE (3rd generation)"]
os_version: ["17.0"]
runs-on: macos-14
os_version: ["18.0"]
runs-on: macos-15
steps:
- uses: actions/checkout@v4
- name: Test
Expand All @@ -44,7 +44,21 @@ jobs:
regenerate_snapshots:
if: ${{ failure() }}
needs: test
uses: ./.github/workflows/regenerate_snapshots.yml
secrets:
SNAPSHOT_PUSH_TOKEN: ${{ secrets.SNAPSHOT_PUSH_TOKEN }}
REF: ${{ github.event.pull_request.head.ref }}
strategy:
matrix:
device: ["iPhone SE (3rd generation)"]
os_version: ["18.0"]
runs-on: macos-15
steps:
- uses: actions/checkout@v4
with:
token: ${{ secrets.SNAPSHOT_PUSH_TOKEN }}
fetch-depth: 0
ref: ${{ github.event.pull_request.head.ref }}
- name: Regenerate Snapshots
run: |
id=$(Automation/get_simulator.py "${{ matrix.device }}" "${{ matrix.os_version }}")
set -o pipefail && xcodebuild test -scheme Orbit-Package -destination "platform=iOS Simulator,id=$id,OS=${{ matrix.os_version }}" OTHER_SWIFT_FLAGS="-D XCODE_IS_SNAPSHOTS_RECORDING" | xcpretty
git -C Snapshots/ add .
git commit -m "Snapshots - ${{ matrix.device }} ${{ matrix.os_version }}" || true
git push
30 changes: 0 additions & 30 deletions .github/workflows/regenerate_snapshots.yml

This file was deleted.

33 changes: 0 additions & 33 deletions Automation/regenerate_snapshots.sh

This file was deleted.

Binary file modified Snapshots/iPhone/AlertInlineTests/testAlerts.1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Snapshots/iPhone/AlertTests/testAlerts.1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Snapshots/iPhone/BadgeListTests/testBadgeLists.1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Snapshots/iPhone/BadgeTests/testBadges.1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Snapshots/iPhone/BadgeTests/testBadges.2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Snapshots/iPhone/BarButtonTests/testBarButton.1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Snapshots/iPhone/ButtonLinkTests/testButtonLinks.1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Snapshots/iPhone/ButtonLinkTests/testButtonLinks.2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Snapshots/iPhone/ButtonTests/testButtons.1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Snapshots/iPhone/ButtonTests/testButtons.2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Snapshots/iPhone/CardTests/testCards.1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Snapshots/iPhone/CarrierLogoTests/testCarrierLogos.1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Snapshots/iPhone/CheckboxTests/testCheckboxes.1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Snapshots/iPhone/ChoiceTileTests/testChoiceTiles.1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Snapshots/iPhone/ChoiceTileTests/testChoiceTiles.2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Snapshots/iPhone/ChoiceTileTests/testChoiceTiles.3.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Snapshots/iPhone/ChoiceTileTests/testChoiceTiles.4.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Snapshots/iPhone/CollapseTests/testCollapse.1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Snapshots/iPhone/CountryFlagTests/testCountryFlags.1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Snapshots/iPhone/CouponTests/testCoupons.1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Snapshots/iPhone/DialogTests/testDialog.1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Snapshots/iPhone/EmptyStateTests/testEmptyStates.1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Snapshots/iPhone/HeadingTests/testHeadings.1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Snapshots/iPhone/HeadingTests/testHeadings.2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Snapshots/iPhone/HeadingTests/testHeadings.3.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Snapshots/iPhone/IconTests/testIcons.1.png
Binary file modified Snapshots/iPhone/IconTests/testIcons.2.png
Binary file modified Snapshots/iPhone/IllustrationTests/testIllustrations.1.png
Binary file modified Snapshots/iPhone/InputContentTests/testInputContent.1.png
Binary file modified Snapshots/iPhone/InputContentTests/testInputContent.2.png
Binary file modified Snapshots/iPhone/InputFieldTests/testInputFields.1.png
Binary file modified Snapshots/iPhone/InputFieldTests/testInputFields.2.png
Binary file modified Snapshots/iPhone/InputFieldTests/testInputFieldsPassword.1.png
Binary file modified Snapshots/iPhone/KeyValueTests/testKeyValues.1.png
Binary file modified Snapshots/iPhone/ListChoiceTests/testListChoices.1.png
Binary file modified Snapshots/iPhone/ListItemTests/testListItems.1.png
Binary file modified Snapshots/iPhone/ListTests/testList.1.png
Binary file modified Snapshots/iPhone/RadioTests/testRadios.1.png
Binary file modified Snapshots/iPhone/SegmentedSwitchTests/testSegmentedSwitch.1.png
Binary file modified Snapshots/iPhone/SegmentedSwitchTests/testSegmentedSwitch.2.png
Binary file modified Snapshots/iPhone/SelectTests/testSelects.1.png
Binary file modified Snapshots/iPhone/SelectTests/testSelects.2.png
Binary file modified Snapshots/iPhone/SelectTests/testSelects.3.png
Binary file modified Snapshots/iPhone/SeparatorTests/testSeparators.1.png
Binary file modified Snapshots/iPhone/SliderTests/testSlider.1.png
Binary file modified Snapshots/iPhone/SocialButtonTests/testSocialButtons.1.png
Binary file modified Snapshots/iPhone/StepperTests/testSteppers.1.png
Binary file modified Snapshots/iPhone/TabsTests/testTabs.1.png
Binary file modified Snapshots/iPhone/TabsTests/testTabs.2.png
Binary file modified Snapshots/iPhone/TagTests/testTags.1.png
Binary file modified Snapshots/iPhone/TagTests/testTags.2.png
Binary file modified Snapshots/iPhone/TextLinkTests/testTextLinks.1.png
Binary file modified Snapshots/iPhone/TextTests/testTexts.1.png
Binary file modified Snapshots/iPhone/TextTests/testTexts.2.png
Binary file modified Snapshots/iPhone/TextTests/testTexts.3.png
Binary file modified Snapshots/iPhone/TextTests/testTexts.4.png
Binary file modified Snapshots/iPhone/TextTests/testTexts.5.png
Binary file modified Snapshots/iPhone/TextTests/testTexts.6.png
Binary file modified Snapshots/iPhone/TextareaTests/testTextarea.1.png
Binary file modified Snapshots/iPhone/TileGroupTests/testTileGroups.1.png
Binary file modified Snapshots/iPhone/TileTests/testTiles.1.png
Binary file modified Snapshots/iPhone/TileTests/testTiles.2.png
Binary file modified Snapshots/iPhone/TileTests/testTiles.3.png
Binary file modified Snapshots/iPhone/TimelineTests/testTimeline.1.png
Binary file modified Snapshots/iPhone/TimelineTests/testTimelineItem.1.png
Binary file modified Snapshots/iPhone/ToastTests/testToasts.1.png
Loading