fix(Accordion): add white background to Header and Footer #4587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domihustinova
changed the title
|
Storybook staging is available at https://kiwicom-orbit-domi-accordion-background.surge.sh |
|
Size Change: +123 B (+0.03%) Total Size: 459 kB
ℹ️ View Unchanged
|
domihustinova
force-pushed
the
domi/accordion-background
branch
from
7f42cb5 to
69da740
Compare
Deploying orbit with
|
| Latest commit: |
6e739b5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ff5baebd.orbit.pages.dev |
| Branch Preview URL: | https://domi-accordion-background.orbit.pages.dev |
domihustinova
commented
Jan 22, 2025
| className={cx( | ||
| "p-600 flex w-full items-center", | ||
| "p-600 bg-white-normal flex w-full items-center rounded-[3px]", |
There was a problem hiding this comment.
I've tried different solutions how to handle this without setting rounded corners but nothing worked properly, mostly because of the shadow on footer 😬
|
Closing. Will be fixed in #4589 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request meets the following criteria:
For new components:
d.tsfiles and are exported inindex.d.ts✨
Description by Callstackai
This PR adds a white background to the Header and Footer of the Accordion component.
Diagrams of code changes
sequenceDiagram participant A as AccordionSection participant H as SectionHeader participant F as SectionFooter Note over A: Updates border styling<br/>border-radius: 4px<br/>border: 1px solid A->>H: Applies calculated inner border-radius Note over H: Sets border-radius: 3px<br/>Updates padding & layout<br/>Adds hover states A->>F: Applies calculated inner border-radius Note over F: Sets border-radius: 3px<br/>Updates shadow & layoutFiles Changed