-
-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure testcase filtering on the API side returns the three duration fields #2531
Conversation
I can squash the two commits into one if this looks good. If we need to ensure filtering on the duration fields works on the API side, I can remove the second commit and leave just d18483b. |
@atodorov I've implemented the changes you requested. I |
75a4188
to
d3352d6
Compare
@atodorov the failure on postgres comes from its inability to cast the duration fields to integer fields or float fields. https://github.com/kiwitcms/Kiwi/pull/2531/checks?check_run_id=3667534662#step:5:1348 |
5288373
to
ccae5f5
Compare
@atodorov please see the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality wise looks good but see the failing black, flake8 and pylint checks. They are all related.
ccae5f5
to
97ea6cd
Compare
This is a more readable/simplified version of PR #2530.
Refs #1923