Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the Hotspot feature from custom apps, and used the normal service instead of foreground service for readAloud feature. #4027

Merged
merged 8 commits into from
Oct 18, 2024

Now we are using normal service instead of foreground service for `re…

f32d0d6
Select commit
Loading
Failed to load commit list.
Merged

Removed the Hotspot feature from custom apps, and used the normal service instead of foreground service for readAloud feature. #4027

Now we are using normal service instead of foreground service for `re…
f32d0d6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 18, 2024 in 0s

58.08% (-0.24%) compared to bad8f4c

View this Pull Request on Codecov

58.08% (-0.24%) compared to bad8f4c

Details

Codecov Report

Attention: Patch coverage is 75.86207% with 7 lines in your changes missing coverage. Please review.

Project coverage is 58.08%. Comparing base (bad8f4c) to head (f32d0d6).

Files with missing lines Patch % Lines
...ile/core/read_aloud/ReadAloudNotificationManger.kt 0.00% 2 Missing ⚠️
...ix/kiwixmobile/core/read_aloud/ReadAloudService.kt 0.00% 2 Missing ⚠️
...iwix/kiwixmobile/di/modules/KiwixActivityModule.kt 0.00% 1 Missing ⚠️
.../org/kiwix/kiwixmobile/di/modules/ServiceModule.kt 88.88% 1 Missing ⚠️
...ile/nav/destination/library/CopyMoveFileHandler.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #4027      +/-   ##
============================================
- Coverage     58.32%   58.08%   -0.24%     
+ Complexity     1601     1505      -96     
============================================
  Files           314      315       +1     
  Lines         13024    13020       -4     
  Branches       1656     1657       +1     
============================================
- Hits           7596     7563      -33     
- Misses         4321     4354      +33     
+ Partials       1107     1103       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov