Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

86 fix CI builds #89

Merged
merged 4 commits into from
Feb 21, 2025
Merged

86 fix CI builds #89

merged 4 commits into from
Feb 21, 2025

Conversation

BPerlakiH
Copy link
Collaborator

Fix CI build, after the merge: #88

@BPerlakiH BPerlakiH changed the title 86 fix ci after dynamic plist 86 fix CI builds Feb 16, 2025
@kelson42
Copy link
Contributor

@BPerlakiH Really unclear what is the problem to fix, what is the principle of the fix.... and why and how the workflow has to be changed.

@BPerlakiH
Copy link
Collaborator Author

There are 2 problems:

  • the former PR was not triggering CI build to run
  • therefore the PR was merged breaking the main branch, which is failing on the CI run

So the solution is to fix it with another PR, making sure from now on the PRs will be triggering the CI run before merging.

@kelson42 kelson42 merged commit c168312 into main Feb 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgaudin rgaudin Awaiting requested review from rgaudin

@kelson42 kelson42 Awaiting requested review from kelson42

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BPerlakiH @kelson42