Fix failure to handle PDFs in openzim archive types #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaifroid
added
bug
regression
Jaifroid
deleted the
Fix-failure-to-handle-PDFs-in-openzim-archive-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1178 . This regression was due to the new Zimit code's passthrough mechanism for reactivating a clicked link. I forgot to turn the passthrough off, so it remained set even when a non-Zimit archive was loaded. Hence, PDFs were not handled properly in such archives if a Zimit archive had been opened in the same session.
The issue is that we must work around the fact that in Chromium browsers PDFs are (rightly IMHO) not trusted to be displayed in a sandbox, as they may have active content. So, in all browsers we open all PDFs in a new tab or window.