[Work In Progress] Gracefully reload the ZIM Library #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor and Improve Code Formatting in kiwix-serve.cpp - Introduced `listenDirectoryChanges()` function (Linux-only) to monitor directory changes and reload the library dynamically. - Used `inotify` to detect modifications in watched directories and trigger library updates. - Implemented a dedicated **monitor thread** to watch for changes in the specified directory. - Ensured proper synchronization and thread safety while handling directory monitoring. - Reformatted and improved code readability by adjusting indentation, spacing, and alignment. - Fixed inconsistent whitespace in function definitions, loops, and conditions. - Standardized `#include` ordering for better organization. - Reordered `#include` statements to maintain consistency across platforms. - Improved error handling by adding better structured `try-catch` blocks. - Standardized macro definitions and improved formatting for readability. - Improved logging messages for better debugging and clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #729
Refactor and Improve Code Formatting in kiwix-serve.cpp
listenDirectoryChanges()function (Linux-only) to monitor directory changes and reload the library dynamically.inotifyto detect modifications in watched directories and trigger library updates.#includeordering for better organization.#includestatements to maintain consistency across platforms.try-catchblocks.Testing
After running the specified command, the console logs indicated a successful configuration reload following modifications to the file
/tmp/zimlibrary/linux_library.xml. To verify the changes, I accessed the web interface athttp://localhost:8080/and confirmed that the library updates were applied as expected.