added comments for getFileContent method moved to pathtool api

kiwix · Sep 26, 2021 · 6bbf4f9 · 6bbf4f9
1 parent 6c5d9e5
commit 6bbf4f9
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/include/tools.h b/include/tools.h
@@ -168,6 +168,13 @@ std::vector<std::string> split(const std::string& str, const std::string& delims
  */
 std::string converta2toa3(const std::string& a2code);
 
+/** Extracts content from given file.
+ *
+ * This function provides content of a file provided it's path.
+ *
+ * @param path The absolute path provided in string format.
+ * @return Content of corresponding file in string format.
+ */
 std::string getFileContent(const std::string& path);
 }
 #endif // KIWIX_TOOLS_H
diff --git a/src/server/internalServer.cpp b/src/server/internalServer.cpp
@@ -138,11 +138,12 @@ InternalServer::InternalServer(Library* library,
   m_withTaskbar(withTaskbar),
   m_withLibraryButton(withLibraryButton),
   m_blockExternalLinks(blockExternalLinks),
-  m_indexTemplateString(indexTemplateString),
   mp_daemon(nullptr),
   mp_library(library),
   mp_nameMapper(nameMapper ? nameMapper : &defaultNameMapper)
-{}
+{
+  m_indexTemplateString = !indexTemplateString.empty() ? indexTemplateString : RESOURCE::templates::index_html;
+}
 
 bool InternalServer::start() {
 #ifdef _WIN32
@@ -338,7 +339,7 @@ InternalServer::get_matching_if_none_match_etag(const RequestContext& r) const
 
 std::unique_ptr<Response> InternalServer::build_homepage(const RequestContext& request)
 {
-  return ContentResponse::build(*this, !m_indexTemplateString.empty() ? m_indexTemplateString : RESOURCE::templates::index_html, get_default_data(), "text/html; charset=utf-8", true);
+  return ContentResponse::build(*this, m_indexTemplateString, get_default_data(), "text/html; charset=utf-8", true);
 }
 
 /**

diff --git a/src/server/internalServer.h b/src/server/internalServer.h
@@ -55,7 +55,7 @@ class InternalServer {
                    bool withTaskbar,
                    bool withLibraryButton,
                    bool blockExternalLinks,
-                   std::string indexTemplateString = "");
+                   std::string indexTemplateString);
     virtual ~InternalServer() = default;
 
     MHD_Result handlerCallback(struct MHD_Connection* connection,