Handling of external links with target="_blank" #1176
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
External links with target="_blank" attribute are opened in a new tab/window.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1176 +/- ##
=======================================
Coverage 41.47% 41.47%
=======================================
Files 59 59
Lines 4272 4272
Branches 2336 2336
=======================================
Hits 1772 1772
Misses 999 999
Partials 1501 1501 ☔ View full report in Codecov by Sentry. |
benoit74
reviewed
Jan 29, 2025
| @@ -355,7 +359,7 @@ function onClickEvent(e) { | |||
|
|
|||
| if (isExternalAppUrl || isExternalUrl(target_href)) { | |||
| const possiblyBlockedLink = blockLink(target_href); | |||
| if ( e.ctrlKey || e.shiftKey ) { | |||
| if ( e.ctrlKey || e.shiftKey || linkShouldBeOpenedInANewWindow(target) ) { | |||
There was a problem hiding this comment.
That's very interesting, this is why it is also not working with MacOS command (⌘) key. I did not dared to speak about it in the issue. I should. I think we should add at least e.metaKey to this list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes kiwix/kiwix-tools#678
External links with
target="_blank"attribute are opened in a new tab/window.