-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fully deprecate Python 2 #130
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unicode strings are the default behaviour in Python 3
Minor Python2 deprecation additions
Unicode strings are the default behaviour in Python 3
Only user-facing methods have typing info for now
Sphinx supports PEP 484 type annotations now
Add initial type hints
wizpig64
reviewed
Nov 25, 2022
Let's just support Python 3.10+ for all the nice new type annotation features 🧨 |
There are some hacks to get the 3.10 syntax working as far back as 3.6, and 3.9 doesn't go EOL until 2025. But if you want to keep the version list short for simplicity, I'd support that decision. I try to keep my keep project running on python's latest. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruff
Backwards incompatible changes:
Keep.login
/Keep.resume
/APIAuth.login
no longer return abool
device_id
parameter previously defaulted toget_mac()
, which returned anint
. This has been updated to cast the int to a hexadecimal string