Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully deprecate Python 2 #130

Merged
merged 62 commits into from
Sep 27, 2023
Merged

Fully deprecate Python 2 #130

merged 62 commits into from
Sep 27, 2023

Conversation

kiwiz
Copy link
Owner

@kiwiz kiwiz commented Oct 14, 2022

  • Remove Python 2 references
  • Integrate ruff
  • Migrate to Github Actions
  • Fix errors with Sphinx docs
  • Review Sphinx docs
  • Testing

Backwards incompatible changes:

  • Bump minimum Python version to 3.10
  • Keep.login/Keep.resume/APIAuth.login no longer return a bool
  • The device_id parameter previously defaulted to get_mac(), which returned an int. This has been updated to cast the int to a hexadecimal string

gkeepapi/__init__.py Outdated Show resolved Hide resolved
@kiwiz
Copy link
Owner Author

kiwiz commented Apr 4, 2023

Let's just support Python 3.10+ for all the nice new type annotation features 🧨

@wizpig64
Copy link
Contributor

wizpig64 commented Apr 4, 2023

There are some hacks to get the 3.10 syntax working as far back as 3.6, and 3.9 doesn't go EOL until 2025. But if you want to keep the version list short for simplicity, I'd support that decision. I try to keep my keep project running on python's latest.

@kiwiz kiwiz mentioned this pull request Sep 21, 2023
@kiwiz kiwiz merged commit d39dc55 into main Sep 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants