Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing hints when not editing at end of line #722

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+13 −3
Open

Fixing hints when not editing at end of line #722

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9f7e481
Display hint directly after cursor - unix only
jerbs Aug 14, 2023
b03ce37
Alt+Right completes hint when not at end of line
jerbs Aug 14, 2023
72bbdf8
Moving the cursor deletes the current hint
jerbs Aug 14, 2023
ea486c0
Completing a hint moves cursor to end of hint
jerbs Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/edit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,8 @@ impl<'out, 'prompt, H: Helper> State<'out, 'prompt, H> {
if self.layout.cursor == cursor {
return Ok(());
}
if self.highlight_char() {
if self.highlight_char() || self.has_hint() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why moving the cursor should invalidate the hint ?
At least, this should be configurable, not hardcoded.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my example in the initial description go the pull request the cursor is moved in steps (3) to (7). In all these positions it does not make sense to insert the remaining partial part of the hint. Try to use it with the app I uploaded https://github.com/jerbs/fsidx. It has a shell mode with hints and completions implemented for long options starting with "--". I don't see in which scenario the currently implemented behaviour is useful.

self.hint = None;
let prompt_size = self.prompt_size;
self.refresh(self.prompt, prompt_size, true, Info::NoHint)?;
} else {
Expand Down