Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set block gas limit in pool to 7M #1517

Merged
merged 4 commits into from
Oct 30, 2024
Merged

set block gas limit in pool to 7M #1517

merged 4 commits into from
Oct 30, 2024

Conversation

tcoratger
Copy link
Collaborator

Should close #1479

Eikix
Eikix reviewed Oct 30, 2024
View reviewed changes
Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we test this?

@tcoratger
Copy link
Collaborator Author

can we test this?

@Eikix

  • I've added a test to validate the gas limit after such a configuration (but in our katana util as we do in main to check)
  • I've added other assertions in our pruning test to check that after each iteration the block gas limit in the pool still is ok

Eikix
Eikix reviewed Oct 30, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
tcoratger
tcoratger commented Oct 30, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@greged93 greged93 merged commit 907b6e8 into kkrt-labs:main Oct 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eikix Eikix Eikix left review comments

@greged93 greged93 greged93 approved these changes

@ClementWalter ClementWalter Awaiting requested review from ClementWalter ClementWalter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: pool gas limit issue [4]
3 participants
@tcoratger @Eikix @greged93