Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use setup from kakarot makefile to ease install #1535

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

matthieuauger
Copy link
Contributor

Time spent on this PR: 2h

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing

What is the new behavior?

When trying to install kakarot-rpc, I faced a several issues with kakarot dependencies:

  • compilation failed because scarb was not installed
  • compilation failed because I downloaded scarb with curl instead of adsm and got wrong version
  • compilation failed because I didn't have foundry

After a few lookups in kakarot code, I saw that there is a setup command that checks everything, we should call it during the setup of kakarot-rpc.

I guess other people didn't face this because they installed kakarot before installing kakarot-rpc

Does this introduce a breaking change?

  • Yes
  • No

@tcoratger tcoratger merged commit 13b0258 into kkrt-labs:main Nov 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants