Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable registration checks #1017

Merged
merged 1 commit into from
Oct 4, 2024
Merged

feat: enable registration checks #1017

merged 1 commit into from
Oct 4, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Oct 4, 2024 •
edited
Loading

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #936

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

This change is Reviewable

@enitrat
Copy link
Collaborator Author

enitrat commented Oct 4, 2024

Closes #136

@enitrat enitrat merged commit 992b891 into main Oct 4, 2024
4 of 5 checks passed
@enitrat enitrat deleted the feat/enable-registration-checks branch October 4, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obatirou obatirou obatirou approved these changes

@ClementWalter ClementWalter Awaiting requested review from ClementWalter ClementWalter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: check starknet caller of register_account function
2 participants
@enitrat @obatirou