Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: safe get evm address #1018

Merged
merged 2 commits into from
Oct 7, 2024
Merged

feat: safe get evm address #1018

merged 2 commits into from
Oct 7, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Oct 4, 2024 •
edited
Loading

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #1016
Resolves: #928

What is the new behavior?

  • Ensure only a Kakarot account can send transactions on behalf of an EVM address

Does this introduce a breaking change?

  • Yes
  • No

This change is Reviewable

@enitrat enitrat requested a review from obatirou October 6, 2024 19:29
@enitrat enitrat merged commit 9203b9c into main Oct 7, 2024
4 of 5 checks passed
@enitrat enitrat deleted the feat/save-get-evm-address branch October 7, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obatirou obatirou obatirou approved these changes

@ClementWalter ClementWalter Awaiting requested review from ClementWalter ClementWalter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: ensure starknet caller is safe evm address feat: use get_starknet_address
2 participants
@enitrat @obatirou