feat: fix coinbase

[Eikix]

Pull Request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Build-related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

The coinbase opcode doesn't give a Kakarot registered EVM address.

Resolves: #577

What is the new behavior?

• The coinbase opcode gives a Kakarot registered EVM address.

Does this introduce a breaking change?

• Yes
• No

[bajpai244]

Created an issue to keep track of the TODO.

[enitrat]

missing test for exec_coinbase

[enitrat]

unless you can't test it yet?

[bajpai244]

unless you can't test it yet?

@enitrat , The current ability to deploy these sequencer accounts on deploy of Kakarot is in TODO, I can setup a test without this functionality as well, I don't think should be an issue, but I don't think that will be a long term solution.

Lemme know, if an interim test works, then I can set one up.

[enitrat]

I can setup a test without this functionality as well, I don't think should be an issue, but I don't think that will be a long term solution.

I think the unit test of exec_coinbase should be decorrelated from the fact that deploying KKT also deploys predefined EOAs. You can deploy a simple EOA, set the sequencer address in a mock to this EOA's SN Address, and then test that coinbase has the right behavior

[Eikix]

I can setup a test without this functionality as well, I don't think should be an issue, but I don't think that will be a long term solution.

I think the unit test of exec_coinbase should be decorrelated from the fact that deploying KKT also deploys predefined EOAs. You can deploy a simple EOA, set the sequencer address in a mock to this EOA's SN Address, and then test that coinbase has the right behavior

Yes the starknet::testing function exists

// Set the sequencer address to the provided value.
pub fn set_sequencer_address(address: ContractAddress) {
    cheatcode::<'set_sequencer_address'>(array![address.into()].span());
}

1. Deploy an EOA
2. Set the sequencer address to the EOA's stakrnet address
3. exec_coinbase
4. Check that the returned address is the EOA's

[bajpai244]

@Eikix, @enitrat added the unit test + added some unwraps to this file where I could see we were missing, done via this commit.