feat: architecture refactor #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eikix
reviewed
Nov 30, 2023
Eikix
reviewed
Dec 1, 2023
Eikix
reviewed
Dec 1, 2023
Eikix
reviewed
Dec 1, 2023
Eikix
reviewed
Dec 1, 2023
Eikix
reviewed
Dec 1, 2023
Eikix
reviewed
Dec 1, 2023
Eikix
reviewed
Dec 1, 2023
Eikix
reviewed
Dec 1, 2023
| /// Prepare the initialization of a new child or so-called sub-context | ||
| /// As part of the CALL family of opcodes. | ||
| fn prepare_call(ref self: Machine, call_type: @CallType) -> Result<CallArgs, EVMError> { | ||
| fn prepare_call(ref self: VM, call_type: @CallType) -> Result<CallArgs, EVMError> { | ||
| let gas = self.stack.pop_u128()?; |
There was a problem hiding this comment.
just realizing here that we can't just accept the gas that is popped from the gas, as it can be maxUint256
we have to take a min,
can create a separate issue though: https://github.com/ethereum/execution-specs/blob/3fe6514f2d9d234e760d11af883a47c1263eff51/src/ethereum/shanghai/vm/instructions/system.py#L370C27-L370C27
There was a problem hiding this comment.
make it a new issue
Eikix
reviewed
Dec 1, 2023
Eikix
reviewed
Dec 1, 2023
|
scarb fmt check |
Eikix
reviewed
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves: #598
What is the new behavior?
Does this introduce a breaking change?