Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cw/fix tests e2e staging #1590

Merged
merged 31 commits into from
Nov 12, 2024

Conversation

ClementWalter
Copy link
Member

@ClementWalter ClementWalter commented Nov 7, 2024

  • Some initial fixes
  • Update deployment folders, works on katana
  • Fix DualVMToken for legacy sn ERC20
  • Fix declaration for StarknetToken
  • Remove useless fixtures
  • Refacto relayers

This change is Reviewable

@ClementWalter ClementWalter force-pushed the cw/fix-tests-e2e-staging branch 2 times, most recently from d743dda to dc602b6 Compare November 8, 2024 11:13
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.7%. Comparing base (d962582) to head (e847268).
Report is 3 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1590   +/-   ##
=====================================
  Coverage   63.6%   63.7%           
=====================================
  Files         44      44           
  Lines       8337    8337           
=====================================
+ Hits        5304    5311    +7     
+ Misses      3033    3026    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the way one runs e2e tests affected? should we add something in the readme about deploying a relayer fleet with a specific private key in env?

@ClementWalter
Copy link
Member Author

ClementWalter commented Nov 10, 2024

image

latest run on staging:

  • all errors are for ercXX test, error in argent multisig api
  • failures are related to updated tests not matching the current deployed kakarot, mutlsig REVERTED raising instead of returning status, state not updated. I'll just investigate the messaging to make sure, otherwise all green to me

Copy link
Collaborator

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end-to-end tests could be pulling the state from SN Sepolia when starting Katana so that we run everything like on a sepolia deployment?

.env.example Show resolved Hide resolved
kakarot_scripts/utils/kakarot.py Show resolved Hide resolved
kakarot_scripts/utils/kakarot.py Show resolved Hide resolved
@ClementWalter ClementWalter merged commit 2121e99 into kkrt-labs:main Nov 12, 2024
13 checks passed
@ClementWalter ClementWalter deleted the cw/fix-tests-e2e-staging branch November 12, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants