Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KGA-64] dev: remove dead code in exec_create #1611

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Nov 15, 2024

https://github.com/code-423n4/2024-09-kakarot-findings/issues/70

Removes a portion of dead code that cheks the return value of the add_transfer function in exec_create. Because the case where the sender doesn't have enough balance is manually handled before, this branch can not be executed.


This change is Reviewable

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.7%. Comparing base (0fbea3a) to head (64f522f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
..._zero/kakarot/instructions/system_operations.cairo 0.0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1611   +/-   ##
=====================================
  Coverage   63.7%   63.7%           
=====================================
  Files         44      44           
  Lines       8362    8359    -3     
=====================================
  Hits        5332    5332           
+ Misses      3030    3027    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementWalter ClementWalter merged commit 36f8cdc into main Nov 15, 2024
16 checks passed
@ClementWalter ClementWalter deleted the fix/dead-code branch November 15, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants