Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KGA-26] [KGA-17] feat: add checks on Starknet return values for DualVMToken #1616

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Nov 18, 2024

https://github.com/code-423n4/2024-09-kakarot-findings/issues/51
https://github.com/code-423n4/2024-09-kakarot-findings/issues/42

Checks the return value for DualVMToken. If the SN call returned false, panicking the EVM call will make the starknet tx revert as a side effect.

Copy link

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.8%. Comparing base (0fbea3a) to head (7bb2860).
Report is 5 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1616   +/-   ##
=====================================
  Coverage   63.7%   63.8%           
=====================================
  Files         44      44           
  Lines       8362    8363    +1     
=====================================
+ Hits        5332    5337    +5     
+ Misses      3030    3026    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

obatirou
obatirou previously approved these changes Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants