[KGA-26] [KGA-17] feat: add checks on Starknet return values for DualVMToken #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1616 +/- ##
=====================================
Coverage 63.7% 63.8%
=====================================
Files 44 44
Lines 8362 8363 +1
=====================================
+ Hits 5332 5337 +5
+ Misses 3030 3026 -4 ☔ View full report in Codecov by Sentry. |
obatirou
reviewed
Nov 18, 2024
obatirou
previously approved these changes
Nov 18, 2024
enitrat
force-pushed
the
fix/check-erc20-return-values
branch
from
8887840
to
146d62d
Compare
obatirou
reviewed
Nov 18, 2024
obatirou
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/code-423n4/2024-09-kakarot-findings/issues/51
https://github.com/code-423n4/2024-09-kakarot-findings/issues/42
Checks the return value for DualVMToken. If the SN call returned false, panicking the EVM call will make the starknet tx revert as a side effect.