-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation Review UI #121
Validation Review UI #121
Conversation
|
More general feedback: Quality Check Popup
Bottom Tab
Indicator
Rules / Validation backend
KPIs / Metrics
|
addComponent({ name, type, x: pos.x, y: pos.y }); | ||
}} | ||
/> | ||
{!isFramed && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Toolbar should still be shown when Framed
const successRatio = ( | ||
passedResults.length / validationResults.length | ||
).toFixed(2); | ||
function createQualityMessage(successRatio) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function can be moved outside the component. As in same file, just before the definition of the Component Function.
if (!isModelValidation(rule)) { | ||
continue; | ||
} | ||
const testResult = rule.test(model); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it runs all rules synchronously, consider using promises?
return <></>; | ||
} | ||
return ( | ||
<Box sx={{ gridArea: "bottom", backgroundColor: "rgb(40,40,40)" }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<Box sx={{ gridArea: "bottom", backgroundColor: "rgb(40,40,40)" }}> | |
<Box sx={{ gridArea: "bottom", backgroundColor: "rgb(30,30,30)" }}> |
This makes it darker and not look blobby with the other panels.
import { modalActions } from "../../../redux/modalSlice"; | ||
import { MODALS } from "../../elements/modal/ModalManager"; | ||
|
||
export function ValidateBeforeReview() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider renaming this to QualityCheck or similar instead, makes it easier to find.
Collapsable bottom panel on the model page to display the validation results
…fig package. fix broken test
return res.sendStatus(400); | ||
if (dal.validationEngine.rules.length === 0) { | ||
return res | ||
.status(404) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
404 here doesn't make sense. It should just return 200 with an empty list. Or are you handling this on the frontend?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
400 errors usually denote client errors, which this is not.
|
||
if (validationResults.length === 0) { | ||
return res | ||
.status(404) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, odd use of 404
New features