Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes and review score in bottom panel #136

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Minor fixes and review score in bottom panel #136

merged 3 commits into from
Nov 20, 2024

Conversation

Tyouxik
Copy link
Collaborator

@Tyouxik Tyouxik commented Nov 20, 2024

Bugs:

  • [Core] Validation engine does not consider the affectedType when selecting rules for a model.
  • [App] When a dataflow is selected, user cannot navigate between the tabs of the bottom panel

Improvement needed:

  • [App] Review score is only available when requesting a review

Fixes:

  • [Core] Validation engines skips rules based on affectedType for component rules
  • [App] When a dataflow is selected, user can navigate between the tabs of the bottom panel. However, when a component is selected, the SELECTED_COMPONENT tab is no longer automatically selected.

Feature:

  • [App] Review score is displayed in the bottom panel next to QUALITY CHECK.

@Tyouxik Tyouxik self-assigned this Nov 20, 2024
@Tyouxik Tyouxik merged commit 62df8c5 into main Nov 20, 2024
1 check passed
@Tyouxik Tyouxik deleted the minor-fixes branch November 20, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tethik Tethik Tethik approved these changes

Assignees

@Tyouxik Tyouxik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyouxik @Tethik