Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Wait for offsets initialization in the control plane #4206

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Jan 9, 2025

Fixes #

Proposed Changes

Release Note


Docs

Copy link

knative-prow bot commented Jan 9, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 9, 2025
@pierDipi
Copy link
Member Author

pierDipi commented Jan 9, 2025

/test ?

Copy link

knative-prow bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested a review from matzew January 9, 2025 13:59
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2025
Copy link

knative-prow bot commented Jan 9, 2025

@pierDipi: The following commands are available to trigger required jobs:

/test build-tests
/test channel-integration-tests-sasl-plain
/test channel-integration-tests-sasl-ssl
/test channel-integration-tests-ssl
/test channel-reconciler-tests-sasl-plain
/test channel-reconciler-tests-sasl-ssl
/test channel-reconciler-tests-ssl
/test integration-tests
/test reconciler-tests
/test reconciler-tests-keda
/test reconciler-tests-namespaced-broker
/test unit-tests
/test upgrade-tests

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 9, 2025
@pierDipi
Copy link
Member Author

pierDipi commented Jan 9, 2025

/test reconciler-tests

@pierDipi
Copy link
Member Author

pierDipi commented Jan 9, 2025

/test unit-tests

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 1.47059% with 67 lines in your changes missing coverage. Please review.

Project coverage is 45.47%. Comparing base (2cde7b9) to head (3c65f70).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
control-plane/pkg/kafka/offset/offsets.go 0.00% 61 Missing ⚠️
...lane/pkg/reconciler/consumergroup/consumergroup.go 14.28% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4206      +/-   ##
==========================================
- Coverage   45.49%   45.47%   -0.02%     
==========================================
  Files         270      269       -1     
  Lines       19873    19882       +9     
==========================================
+ Hits         9041     9042       +1     
- Misses      10113    10119       +6     
- Partials      719      721       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

knative-prow bot commented Jan 9, 2025

@pierDipi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
reconciler-tests_eventing-kafka-broker_main 3c65f70 link true /test reconciler-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Cali0707
Copy link
Member

Cali0707 commented Jan 9, 2025

@pierDipi what's the purpose behind waiting for offsets in the control plane? is it to ensure that the consumergroup rebalance has finished before we say that the trigger is ready?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants