[WIP] Fix KEDA scaling with SASL auth for brokers #4253
Conversation
TriggerAuthentication is misconfigured when Broker is configured to connect to Kafka with SASL since it was using only the legacy secret format. Signed-off-by: Pierangelo Di Pilato <[email protected]>
knative-prow
bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
size/L
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4253 +/- ##
==========================================
+ Coverage 45.32% 45.35% +0.02%
==========================================
Files 290 290
Lines 19869 19863 -6
==========================================
+ Hits 9005 9008 +3
+ Misses 10151 10143 -8
+ Partials 713 712 -1 ☔ View full report in Codecov by Sentry. |
|
@pierDipi: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| virtualSecret.Data[SaslMechanismKey] = v | ||
| } | ||
| if v, ok := virtualSecret.Data["saslType"]; ok { | ||
| if v, ok := virtualSecret.Data[SaslTypeLegacy]; ok { |
There was a problem hiding this comment.
when can we remove this legacy?
TriggerAuthentication is misconfigured when Broker is configured to connect to Kafka with SASL since it was using only the legacy secret format.
Fixes #
Proposed Changes
Release Note
Docs